Merged
Conversation
Change the code style guide.
Contributor
|
I will test it later. |
jfb8856606
reviewed
May 30, 2024
| } | ||
| if (!knlist_empty(&kq->kq_sel.si_note)) | ||
| #ifndef FSTACK | ||
| kqueue_schedtask(kq); |
Contributor
There was a problem hiding this comment.
gcc build error :kern_event.c:1676:1: error: ‘kqueue_schedtask’ defined but not used
May be you also use #ifndef FSTACK and '#endif' to protect the definition of kqueue_schedtask in line 1676.
modify gcc build error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After making these modifications, f-stack will support QAT accelerator cards.
When kqueue A is added as an event to kqueue B, kqueue B cannot detect when a new event is added to kqueue A.
FreeBSD supports this feature by starting a thread in kernel mode to handle it, ultimately using the
kqueue_taskfunction to notify the kqueue.When a new event is added to kqueue A, the
kqueue_wakeupfunction is triggered.Therefore, by modifying the implementation to trigger events in a manner similar to
kqueue_task, this functionality can be achieved.For f-stack to support QAT accelerator cards, the following steps are necessary:
asynch_mode_nginx.By doing so, f-stack will be able to support QAT accelerator cards.