Add keyboard shortcuts support when using UIKit for Mac (Project Catalyst)#305
Add keyboard shortcuts support when using UIKit for Mac (Project Catalyst)#305revolter wants to merge 9 commits intoFLEXTool:masterfrom
Conversation
|
Can you explain your changes and your approach? I'm wary of accepting something that uses the preprocessor to change the superclass of one of our classes |
|
Well, I know it's a bit hacky, but I tried to fix it with minimal changes. I forgot to add usage sample code though. You have to overwrite the The thing is that the only way to make it work is to return actual instances of |
5212824 to
e2a3343
Compare
464f29a to
e18a854
Compare
1a177c8 to
3b5e095
Compare
b4cb311 to
ffa658c
Compare
|
Random question: what does FLEX even look like in a Catalyst app? |
|
Well, we don't develop the Mac app anymore, so I can't check it out, and I also don't remember. But, at least in our case, since the Mac app was a window with a size (or at least an aspect ratio) of an iPad, both the app and FLEX looked like on a regular iPad. |
|
Well since it's not a priority right now I'm gonna close this :P If you plan on deleting the associated branch, let me know so I can fork it; I don't want your work to go to waste if I do eventually get around to this |
Sooo, I agreed with you, but then I thought that I could add Catalyst apps to the example project(s), so that contributors have the ability to test PRs like this one directly. But after downloading the repo, I noticed that both the CocoaPods and the SPM example projects have a catalyst app added: Knowing this, I'll try to rebase the branch. |
|
Actually, I think that I can run the app on my Mac because I have it's M1. |
|
Apparently, it works even if you don't override the |
|
@NSExceptional, this is now ready for review |
|
Did you rebase it? Still says there are conflicts |
|
Could you try reopening the PR? Because I did force push it: |
f7659a8 to
1c91354
Compare
1c91354 to
4bcf0a0
Compare

Fixes #297.