Repository navigation
Jakarta does not have jakarta.validation as module-info dependency #161
Description
I got an error!
java.lang.module.FindException: Module validation.api not found, required by com.fasterxml.jackson.module.jsonSchema.jakarta
when I found jackson-module-jsonSchema-jakarta's module-info.class, It used validation.api
module com.fasterxml.jackson.module.jsonSchema.jakarta {
requires validation.api;
requires com.fasterxml.jackson.annotation;
requires com.fasterxml.jackson.core;
requires com.fasterxml.jackson.databind;
exports com.fasterxml.jackson.module.jsonSchema.jakarta;
exports com.fasterxml.jackson.module.jsonSchema.jakarta.annotation;
exports com.fasterxml.jackson.module.jsonSchema.jakarta.customProperties;
exports com.fasterxml.jackson.module.jsonSchema.jakarta.factories;
exports com.fasterxml.jackson.module.jsonSchema.jakarta.types;
exports com.fasterxml.jackson.module.jsonSchema.jakarta.validation;
}But I check your source code, used validation.api.
Now, I have 2 question
- why choice
validation.api - how can fix my probrom?
thank you very much
Activity
oldmanpushcart commentedon Dec 15, 2024
about question1, I found #150
pjfanning commentedon Dec 15, 2024
That module-info setting is probably an oversight. Based on https://github.com/jakartaee/validation/blob/main/src/main/java/module-info.java, it should probably be jakarta.validation.
Let me have a look.
pjfanning commentedon Dec 15, 2024
@oldmanpushcart I have added #162. Would you be able to make this change and build jackson-module-jsonSchema for yourself to try the jar with the change?
cowtowncoder commentedon Dec 17, 2024
Yes, I think this must have been copy-paste error by submitted of Jakarta version (and one code reviewer (me) did not catch).
#162 seems legit (and I will merge) but verification by @oldmanpushcart would be much appreciated.
[-]why jakarta don't use jakarta.validation?[/-][+]Jakarta does not have `jakarta.validation` as `module-info` dependency[/+]Update release notes #161 fix
oldmanpushcart commentedon Dec 19, 2024
@pjfanning I build master(2.19.0-SNAPSHOT) on my laptop, It's work's fine. Thank you very much~
@cowtowncoder verification pass. Hope we can see the feature in 2.18.3
cowtowncoder commentedon Dec 19, 2024
Thank you for verifying, @oldmanpushcart .