feat: add delete multiple pieces functionality#586
Closed
akronim26 wants to merge 1 commit intoFilOzone:masterfrom
Closed
feat: add delete multiple pieces functionality#586akronim26 wants to merge 1 commit intoFilOzone:masterfrom
akronim26 wants to merge 1 commit intoFilOzone:masterfrom
Conversation
wjmelements
reviewed
Feb 3, 2026
| export async function deletePieces(options: deletePieces.OptionsType): Promise<deletePieces.ReturnType> { | ||
| const { endpoint, dataSetId, pieceIds, extraData } = options | ||
| const response = await request.json.post<deletePieces.ReturnType>( | ||
| new URL(`pdp/data-sets/${dataSetId}/pieces/removals`, endpoint), |
Contributor
There was a problem hiding this comment.
I don't think curio has this endpoint yet. If you are working on that too, please link your PR. It should target the pdpv0 branch.
Collaborator
|
Closing this for now, sorry @akronim26, but since we don't have a matching API for curio yet, and that work is actually going to be the hard part of this, then we'll wait till we have it there before we do it here so we avoid the bitrot of having a PR open and waiting. It's not lost work, it's just going to be harder to keep this open and rebased until we're ready for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of deleting multiple pieces from a dataset in one go. It resolves #551.