Skip to content

chore: Add client_name to separate experimentation connection#8034

Merged
matthewelwell merged 5 commits into
mainfrom
chore/add-client_name-to-experimentation-ch-connection
Jul 17, 2026
Merged

chore: Add client_name to separate experimentation connection#8034
matthewelwell merged 5 commits into
mainfrom
chore/add-client_name-to-experimentation-ch-connection

Conversation

@matthewelwell

@matthewelwell matthewelwell commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds client_name parameter to separate experimentation connection to ClickHouse.

How did you test this code?

N/a - trivial change based on documentation.

@matthewelwell
matthewelwell requested review from a team as code owners July 17, 2026 09:39
@matthewelwell
matthewelwell requested review from khvn26 and removed request for a team July 17, 2026 09:39
@vercel

vercel Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 17, 2026 1:28pm
flagsmith-frontend-preview Ignored Ignored Preview Jul 17, 2026 1:28pm
flagsmith-frontend-staging Ignored Ignored Preview Jul 17, 2026 1:28pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 10bba6fd-f19d-42b8-a469-ff6c7c0133d7

📥 Commits

Reviewing files that changed from the base of the PR and between f822d5d and b87de8c.

📒 Files selected for processing (1)
  • api/tests/unit/experimentation/test_services.py
📝 Walkthrough

Walkthrough

The ClickHouse settings add a shared client identifier, relocate the experimentation ClickHouse URL declaration, and include the identifier in database options. Experimentation client construction now supplies the identifier when no existing client name is provided. Four warehouse event catalogue references and the related unit test expectation are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added api Issue related to the REST API docs Documentation updates labels Jul 17, 2026
coderabbitai[bot]
coderabbitai Bot reviewed Jul 17, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eedd7a99-2271-4b4a-b693-9e067e2a223e

📥 Commits

Reviewing files that changed from the base of the PR and between 4df9bfb and 68e3f42.

📒 Files selected for processing (3)
  • api/app/settings/common.py
  • api/experimentation/services.py
  • docs/docs/deployment-self-hosting/observability/_events-catalogue.md

Comment thread api/experimentation/services.py
@matthewelwell
matthewelwell force-pushed the chore/add-client_name-to-experimentation-ch-connection branch from 68e3f42 to f2471ab Compare July 17, 2026 09:48
@github-actions github-actions Bot removed the docs Documentation updates label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8034 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8034 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-8034 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8034 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8034 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8034 Finished ✅ Results ✅

@github-actions github-actions Bot added the chore label Jul 17, 2026
@github-actions github-actions Bot added docs Documentation updates chore and removed docs Documentation updates chore labels Jul 17, 2026
coderabbitai[bot]
coderabbitai Bot reviewed Jul 17, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 98e7db43-4050-4bb1-a4b2-04b53ab587df

📥 Commits

Reviewing files that changed from the base of the PR and between f2471ab and f822d5d.

📒 Files selected for processing (1)
  • api/tests/unit/experimentation/test_services.py

Comment thread api/tests/unit/experimentation/test_services.py Outdated
@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.1 seconds
commit  f2471ab
info  🔄 Run: #18431 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.8 seconds
commit  f2471ab
info  🔄 Run: #18431 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  6.5 seconds
commit  f2471ab
info  🔄 Run: #18431 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  35.8 seconds
commit  f2471ab
info  🔄 Run: #18431 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.8 seconds
commit  f822d5d
info  🔄 Run: #18432 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47 seconds
commit  f822d5d
info  🔄 Run: #18432 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  17.6 seconds
commit  f822d5d
info  🔄 Run: #18432 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 1 second
commit  f822d5d
info  🔄 Run: #18432 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  33.4 seconds
commit  68fcf2a
info  🔄 Run: #18437 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  4.9 seconds
commit  b87de8c
info  🔄 Run: #18436 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.8 seconds
commit  b87de8c
info  🔄 Run: #18436 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  32.2 seconds
commit  b87de8c
info  🔄 Run: #18436 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.2 seconds
commit  68fcf2a
info  🔄 Run: #18437 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.8 seconds
commit  b87de8c
info  🔄 Run: #18436 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  39.1 seconds
commit  68fcf2a
info  🔄 Run: #18437 (attempt 1)

@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added the docs Documentation updates label Jul 17, 2026
@github-actions github-actions Bot removed docs Documentation updates chore labels Jul 17, 2026
@github-actions github-actions Bot added chore docs Documentation updates and removed docs Documentation updates chore labels Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (4df9bfb) to head (68fcf2a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8034   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files        1506     1506           
  Lines       59572    59573    +1     
=======================================
+ Hits        58766    58767    +1     
  Misses        806      806

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell
matthewelwell merged commit 49ea147 into main Jul 17, 2026
34 checks passed
@matthewelwell
matthewelwell deleted the chore/add-client_name-to-experimentation-ch-connection branch July 17, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@khvn26 khvn26 khvn26 approved these changes
@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

Assignees

No one assigned

Labels

api Issue related to the REST API chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewelwell @khvn26 @gagantrivedi