-
Notifications
You must be signed in to change notification settings - Fork 74
Add audio node class field #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a missing className field to the ui-audio node to enable user styling, bringing it in line with other widgets in the package. The change only applies when the audio node is in "src" mode (audio player mode), not in "tts" (text-to-speech) mode.
Changes:
- Added
classNameconfiguration field to ui-audio node with localization support - Implemented comprehensive unit test coverage (100%) for both audio player and TTS modes
- Fixed datastore cleanup in TTS mode (changed from non-existent
removemethod toclearand addedstatestore.reset)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| nodes/widgets/ui_audio.html | Added className field to node configuration UI with i18n support |
| nodes/widgets/ui_audio.js | Fixed TTS mode cleanup to use correct datastore.clear and statestore.reset methods |
| nodes/widgets/locales/en-US/ui_audio.json | Added English translations for className field |
| nodes/widgets/locales/de/ui_audio.json | Added German translations for className field |
| test/nodes/widgets/ui_audio.spec.js | Added comprehensive test suite with 100% coverage for audio node |
| test/nodes/utils.js | Added utility functions for testing widget registration |
| package.json | Added test coverage scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sorry @Steve-Mcl I am out of action for a couple of weeks. |
|
@cstns any chance of a review here please? |
|
I had it on my radar this morning and it managed to slip through the cracks.. I'll do it first thing tomorrow |
Description
Add missing
classfield to audio node like all other nodes in the package - to permit user stylingNOTE: the audio node class is only relevant when mode is src (i.e. a player is rendered)
Tests
Adds 100% unit test coverage
Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel