fix(eslint): enforce type import

.eslintrc.js

@@ -56,6 +56,12 @@ module.exports = {
     // No unused variables
     '@typescript-eslint/no-unused-vars': ['error'],
 
+    // Enforce type imports for type-only imports
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      { prefer: 'type-imports', fixStyle: 'separate-type-imports' },
+    ],
+
     // No reassigning function parameters
     'no-param-reassign': ['error', { props: false }],
 

packages/_example/src/forest/agent.ts

@@ -1,4 +1,7 @@
-import { AgentOptions, createAgent } from '@forestadmin/agent';
+import type { Schema } from './typings';
+import type { AgentOptions } from '@forestadmin/agent';
+
+import { createAgent } from '@forestadmin/agent';
 import { createMongoDataSource } from '@forestadmin/datasource-mongo';
 import { createMongooseDataSource } from '@forestadmin/datasource-mongoose';
 import { createSequelizeDataSource } from '@forestadmin/datasource-sequelize';
@@ -16,7 +19,6 @@ import customizeReview from './customizations/review';
 import customizeSales from './customizations/sale';
 import customizeStore from './customizations/store';
 import createTypicode from './datasources/typicode';
-import { Schema } from './typings';
 import mongoose, { connectionString } from '../connections/mongoose';
 import sequelizeMsSql from '../connections/sequelize-mssql';
 import sequelizeMySql from '../connections/sequelize-mysql';

packages/_example/src/forest/customizations/account.ts

@@ -1,4 +1,4 @@
-import { AccountCustomizer } from '../typings';
+import type { AccountCustomizer } from '../typings';
 
 export default (collection: AccountCustomizer) =>
   collection.addManyToOneRelation('store', 'store', { foreignKey: 'storeId' });

packages/_example/src/forest/customizations/card.ts

@@ -1,4 +1,4 @@
-import { CardCustomizer } from '../typings';
+import type { CardCustomizer } from '../typings';
 
 export default (collection: CardCustomizer) =>
   collection

packages/_example/src/forest/customizations/comment.ts

@@ -1,4 +1,4 @@
-import { CommentCustomizer } from '../typings';
+import type { CommentCustomizer } from '../typings';
 
 export default (collection: CommentCustomizer) =>
   collection.addManyToOneRelation('post', 'post', { foreignKey: 'postId' });

packages/_example/src/forest/customizations/customer.ts

@@ -1,4 +1,4 @@
-import { CustomerCustomizer } from '../typings';
+import type { CustomerCustomizer } from '../typings';
 
 export default (collection: CustomerCustomizer) =>
   collection

packages/_example/src/forest/customizations/dvd.ts

@@ -1,5 +1,6 @@
+import type { DvdCustomizer } from '../typings';
+
 import sequelizeMsSql from '../../connections/sequelize-mssql';
-import { DvdCustomizer } from '../typings';
 
 export default (collection: DvdCustomizer) =>
   collection

packages/_example/src/forest/customizations/owner.ts

@@ -1,4 +1,4 @@
-import { OwnerCustomizer } from '../typings';
+import type { OwnerCustomizer } from '../typings';
 
 export default (collection: OwnerCustomizer) =>
   collection

packages/_example/src/forest/customizations/post.ts

@@ -1,4 +1,4 @@
-import { PostCustomizer } from '../typings';
+import type { PostCustomizer } from '../typings';
 
 export default (collection: PostCustomizer) =>
   collection

packages/_example/src/forest/customizations/rental.ts

@@ -1,4 +1,4 @@
-import { RentalCustomizer } from '../typings';
+import type { RentalCustomizer } from '../typings';
 
 export default (collection: RentalCustomizer) =>
   collection

packages/_example/src/forest/customizations/review.ts

@@ -1,4 +1,4 @@
-import { ReviewCustomizer } from '../typings';
+import type { ReviewCustomizer } from '../typings';
 
 export default (collection: ReviewCustomizer) =>
   collection.addManyToOneRelation('store', 'store', { foreignKey: 'storeId' });

packages/_example/src/forest/customizations/sale.ts

@@ -1,4 +1,4 @@
-import { SalesCustomizer } from '../typings';
+import type { SalesCustomizer } from '../typings';
 
 export default (collection: SalesCustomizer) =>
   collection.addManyToOneRelation('customerAccount', 'account', {

packages/_example/src/forest/customizations/store.ts

@@ -1,4 +1,4 @@
-import { StoreCustomizer } from '../typings';
+import type { StoreCustomizer } from '../typings';
 
 export default (collection: StoreCustomizer) =>
   collection

packages/_example/src/forest/datasources/typicode.ts

@@ -1,10 +1,8 @@
 /* eslint-disable max-classes-per-file */
 
-import {
+import type {
   AggregateResult,
   Aggregation,
-  BaseCollection,
-  BaseDataSource,
   Caller,
   DataSource,
   DataSourceFactory,
@@ -14,6 +12,8 @@ import {
   Projection,
   RecordData,
 } from '@forestadmin/datasource-toolkit';
+
+import { BaseCollection, BaseDataSource } from '@forestadmin/datasource-toolkit';
 import superagent from 'superagent';
 
 class TypicodeCollection extends BaseCollection {

packages/_example/src/frameworks/nest-fastify-v8.ts

@@ -1,7 +1,10 @@
 /* eslint-disable max-classes-per-file */
-import { Controller, Get, INestApplication, Module } from '@nestjs/common';
+import type { INestApplication } from '@nestjs/common';
+import type { NestFastifyApplication } from '@nestjs/platform-fastify';
+
+import { Controller, Get, Module } from '@nestjs/common';
 import { NestFactory } from '@nestjs/core';
-import { FastifyAdapter, NestFastifyApplication } from '@nestjs/platform-fastify';
+import { FastifyAdapter } from '@nestjs/platform-fastify';
 
 @Controller('/')
 class BasicController {

packages/agent-client/src/action-fields/action-field-checkbox-group.ts

@@ -1,5 +1,6 @@
+import type { PlainFieldOption } from './types';
+
 import ActionField from './action-field';
-import { PlainFieldOption } from './types';
 
 export default class ActionFieldCheckboxGroup extends ActionField {
   getOptions(): PlainFieldOption[] | undefined {

packages/agent-client/src/action-fields/action-field-dropdown.ts

@@ -1,5 +1,6 @@
+import type { PlainFieldOption } from './types';
+
 import ActionField from './action-field';
-import { PlainFieldOption } from './types';
 
 export default class ActionFieldDropdown extends ActionField {
   getOptions(): PlainFieldOption[] | undefined {

packages/agent-client/src/action-fields/action-field-multiple-choice.ts

@@ -1,5 +1,6 @@
+import type { PlainFieldOption } from './types';
+
 import FieldGetter from './field-getter';
-import { PlainFieldOption } from './types';
 
 export default class ActionFieldMultipleChoice extends FieldGetter {
   getOptions(): PlainFieldOption[] | undefined {

packages/agent-client/src/action-fields/action-field-radio-group.ts

@@ -1,5 +1,6 @@
+import type { PlainFieldOption } from './types';
+
 import ActionField from './action-field';
-import { PlainFieldOption } from './types';
 
 export default class ActionFieldRadioGroup extends ActionField {
   async getOptions(): Promise<PlainFieldOption[] | undefined> {

packages/agent-client/src/action-fields/action-field.ts

@@ -1,4 +1,4 @@
-import FieldFormStates from './field-form-states';
+import type FieldFormStates from './field-form-states';
 
 export default abstract class ActionField {
   private readonly fieldsFormStates: FieldFormStates;

packages/agent-client/src/action-fields/field-form-states.ts

@@ -1,9 +1,9 @@
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { PlainField, ResponseBody } from './types';
+import type HttpRequester from '../http-requester';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 import ActionFieldMultipleChoice from './action-field-multiple-choice';
 import FieldGetter from './field-getter';
-import { PlainField, ResponseBody } from './types';
-import HttpRequester from '../http-requester';
 
 export default class FieldFormStates {
   private readonly fields: FieldGetter[];

packages/agent-client/src/action-fields/field-getter.ts

@@ -1,4 +1,4 @@
-import { PlainField } from './types';
+import type { PlainField } from './types';
 
 export default class FieldGetter {
   private readonly plainField: PlainField;

packages/agent-client/src/action-fields/types.ts

@@ -1,4 +1,4 @@
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 export type ResponseBody = {
   fields: PlainField[];

packages/agent-client/src/action-layout/action-layout-container.ts

@@ -1,4 +1,4 @@
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 import ActionLayoutElement from './action-layout-element';
 import { NotFoundElementError, NotRightElementError } from './errors';

packages/agent-client/src/action-layout/action-layout-element.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   ForestServerActionFormElementFieldReference,
   ForestServerActionFormLayoutElement,
 } from '@forestadmin/forestadmin-client';

packages/agent-client/src/action-layout/action-layout-input.ts

@@ -1,4 +1,4 @@
-import { ForestServerActionFormElementFieldReference } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormElementFieldReference } from '@forestadmin/forestadmin-client';
 
 export default class ActionLayoutInput {
   protected readonly layoutItem: ForestServerActionFormElementFieldReference;

packages/agent-client/src/action-layout/action-layout-page.ts

@@ -1,4 +1,4 @@
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 import ActionLayoutElementsContainer from './action-layout-container';
 import { NotRightElementError } from './errors';

packages/agent-client/src/action-layout/errors.ts

@@ -1,5 +1,5 @@
 // eslint-disable-next-line max-classes-per-file
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 export class NotRightElementError extends Error {
   constructor(elementName: string, element: ForestServerActionFormLayoutElement) {

packages/agent-client/src/domains/action.ts

@@ -1,6 +1,7 @@
+import type ActionField from '../action-fields/action-field';
+import type FieldFormStates from '../action-fields/field-form-states';
 import type HttpRequester from '../http-requester';
 
-import ActionField from '../action-fields/action-field';
 import ActionFieldCheckbox from '../action-fields/action-field-checkbox';
 import ActionFieldCheckboxGroup from '../action-fields/action-field-checkbox-group';
 import ActionFieldColorPicker from '../action-fields/action-field-color-picker';
@@ -13,7 +14,6 @@ import ActionFieldNumberList from '../action-fields/action-field-number-list';
 import ActionFieldRadioGroup from '../action-fields/action-field-radio-group';
 import ActionFieldString from '../action-fields/action-field-string';
 import ActionFieldStringList from '../action-fields/action-field-string-list';
-import FieldFormStates from '../action-fields/field-form-states';
 import ActionLayoutRoot from '../action-layout/action-layout-root';
 
 export type BaseActionContext = {

packages/agent-client/src/domains/chart.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   DistributionChart,
   LeaderboardChart,
   ObjectiveChart,

packages/agent-client/src/domains/collection-chart.ts

@@ -1,4 +1,5 @@
-import {
+import type { ChartInterface } from './chart';
+import type {
   DistributionChart,
   LeaderboardChart,
   ObjectiveChart,
@@ -7,7 +8,6 @@ import {
   ValueChart,
 } from '@forestadmin/datasource-toolkit';
 
-import { ChartInterface } from './chart';
 import HttpRequester from '../http-requester';
 
 export type ChartContext = {

packages/agent-client/src/domains/collection.ts

@@ -1,13 +1,13 @@
 import type { ExportOptions, LiveQueryOptions, SelectOptions } from '../types';
+import type { ActionEndpointsByCollection, BaseActionContext } from './action';
+import type HttpRequester from '../http-requester';
+import type { WriteStream } from 'fs';
 
-import { WriteStream } from 'fs';
-
-import Action, { ActionEndpointsByCollection, BaseActionContext } from './action';
+import Action from './action';
 import CollectionChart from './collection-chart';
 import Relation from './relation';
 import Segment from './segment';
 import FieldFormStates from '../action-fields/field-form-states';
-import HttpRequester from '../http-requester';
 import QuerySerializer from '../query-serializer';
 
 export default class Collection extends CollectionChart {

packages/agent-client/src/domains/remote-agent-client.ts

@@ -1,9 +1,9 @@
-import { RawTreeWithSources } from '@forestadmin/forestadmin-client';
+import type { ActionEndpointsByCollection } from './action';
+import type HttpRequester from '../http-requester';
+import type { RawTreeWithSources } from '@forestadmin/forestadmin-client';
 
-import { ActionEndpointsByCollection } from './action';
 import Chart from './chart';
 import Collection from './collection';
-import HttpRequester from '../http-requester';
 
 export type SmartActionPermissionsOverride = Partial<{
   triggerEnabled: boolean;

packages/agent-client/src/domains/segment.ts

@@ -1,7 +1,6 @@
 import type HttpRequester from '../http-requester';
 import type { ExportOptions, LiveQueryOptions, SelectOptions } from '../types';
-
-import { WriteStream } from 'node:fs';
+import type { WriteStream } from 'node:fs';
 
 import QuerySerializer from '../query-serializer';
 

packages/agent-client/src/http-requester.ts

@@ -1,4 +1,5 @@
-import { WriteStream } from 'fs';
+import type { WriteStream } from 'fs';
+
 import { Deserializer } from 'jsonapi-serializer';
 import superagent from 'superagent';
 

packages/agent-client/src/index.ts

@@ -1,5 +1,7 @@
-import { ActionEndpointsByCollection } from './domains/action';
-import RemoteAgentClient, { PermissionsOverride } from './domains/remote-agent-client';
+import type { ActionEndpointsByCollection } from './domains/action';
+import type { PermissionsOverride } from './domains/remote-agent-client';
+
+import RemoteAgentClient from './domains/remote-agent-client';
 import HttpRequester from './http-requester';
 
 // eslint-disable-next-line import/prefer-default-export

packages/agent-client/src/types.ts

@@ -1,4 +1,4 @@
-import { PlainFilter, PlainSortClause } from '@forestadmin/datasource-toolkit';
+import type { PlainFilter, PlainSortClause } from '@forestadmin/datasource-toolkit';
 
 export type BaseOptions = {
   filters?: PlainFilter['conditionTree']; // Filters to apply to the query

packages/agent-client/test/action-fields/action-field-multiple-choice.test.ts

@@ -1,5 +1,6 @@
+import type { PlainField, PlainFieldOption } from '../../src/action-fields/types';
+
 import ActionFieldMultipleChoice from '../../src/action-fields/action-field-multiple-choice';
-import { PlainField, PlainFieldOption } from '../../src/action-fields/types';
 
 describe('ActionFieldMultipleChoice', () => {
   const createPlainField = (options?: PlainFieldOption[], value?: unknown): PlainField => ({

packages/agent-client/test/action-fields/action-fields.test.ts

@@ -1,3 +1,5 @@
+import type HttpRequester from '../../src/http-requester';
+
 import ActionFieldCheckbox from '../../src/action-fields/action-field-checkbox';
 import ActionFieldCheckboxGroup from '../../src/action-fields/action-field-checkbox-group';
 import ActionFieldColorPicker from '../../src/action-fields/action-field-color-picker';
@@ -11,7 +13,6 @@
 import ActionFieldString from '../../src/action-fields/action-field-string';
 import ActionFieldStringList from '../../src/action-fields/action-field-string-list';
 import FieldFormStates from '../../src/action-fields/field-form-states';
-import HttpRequester from '../../src/http-requester';
 
 jest.mock('../../src/http-requester');
 
@@ -21,7 +22,7 @@
 
   beforeEach(() => {
     jest.clearAllMocks();
     httpRequester = { query: jest.fn() } as any;
     fieldFormStates = new FieldFormStates(
       'testAction',
       '/forest/actions/test',
@@ -31,7 +32,7 @@
     );
   });
 
   const setupFields = async (fields: any[]) => {
     httpRequester.query.mockResolvedValue({ fields, layout: [] });
     await fieldFormStates.loadInitialState();
   };

packages/agent-client/test/action-fields/field-form-states.test.ts

@@ -1,5 +1,6 @@
+import type HttpRequester from '../../src/http-requester';
+
 import FieldFormStates from '../../src/action-fields/field-form-states';
-import HttpRequester from '../../src/http-requester';
 
 jest.mock('../../src/http-requester');
 
@@ -11,7 +12,7 @@
     jest.clearAllMocks();
     httpRequester = {
       query: jest.fn(),
     } as any;
     fieldFormStates = new FieldFormStates(
       'testAction',
       '/forest/actions/test-action',

packages/agent-client/test/action-fields/field-getter.test.ts

@@ -1,5 +1,6 @@
+import type { PlainField } from '../../src/action-fields/types';
+
 import FieldGetter from '../../src/action-fields/field-getter';
-import { PlainField } from '../../src/action-fields/types';
 
 describe('FieldGetter', () => {
   const createPlainField = (overrides: Partial<PlainField> = {}): PlainField => ({

packages/agent-client/test/action-layout/action-layout.test.ts

@@ -1,4 +1,4 @@
-import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
+import type { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
 
 import ActionLayoutElement from '../../src/action-layout/action-layout-element';
 import ActionLayoutInput from '../../src/action-layout/action-layout-input';
@@ -26,7 +26,7 @@
 
   describe('ActionLayoutInput', () => {
     it('should return the field id', () => {
       const layoutItem = { component: 'input', fieldId: 'myField' } as any;
       const input = new ActionLayoutInput(layoutItem);
 
       expect(input.getInputId()).toBe('myField');
@@ -36,24 +36,24 @@
   describe('ActionLayoutElement', () => {
     describe('isRow', () => {
       it('should return true for row component', () => {
         const element = new ActionLayoutElement({ component: 'row', fields: [] } as any);
         expect(element.isRow()).toBe(true);
       });
 
       it('should return false for non-row component', () => {
         const element = new ActionLayoutElement({ component: 'input', fieldId: 'test' } as any);
         expect(element.isRow()).toBe(false);
       });
     });
 
     describe('isInput', () => {
       it('should return true for input component', () => {
         const element = new ActionLayoutElement({ component: 'input', fieldId: 'test' } as any);
         expect(element.isInput()).toBe(true);
       });
 
       it('should return false for non-input component', () => {
         const element = new ActionLayoutElement({ component: 'separator' } as any);
         expect(element.isInput()).toBe(false);
       });
     });
@@ -63,12 +63,12 @@
         const element = new ActionLayoutElement({
           component: 'htmlBlock',
           content: '<p>Hello</p>',
         } as any);
         expect(element.isHTMLBlock()).toBe(true);
       });
 
       it('should return false for non-htmlBlock component', () => {
         const element = new ActionLayoutElement({ component: 'input', fieldId: 'test' } as any);
         expect(element.isHTMLBlock()).toBe(false);
       });
     });

packages/agent-client/test/domains/action.test.ts

@@ -1,6 +1,7 @@
-import FieldFormStates from '../../src/action-fields/field-form-states';
+import type FieldFormStates from '../../src/action-fields/field-form-states';
+import type HttpRequester from '../../src/http-requester';
+
 import Action from '../../src/domains/action';
-import HttpRequester from '../../src/http-requester';
 
 jest.mock('../../src/http-requester');
 jest.mock('../../src/action-fields/field-form-states');

packages/agent-client/test/domains/chart.test.ts

@@ -1,5 +1,6 @@
+import type HttpRequester from '../../src/http-requester';
+
 import Chart from '../../src/domains/chart';
-import HttpRequester from '../../src/http-requester';
 
 // Create a concrete implementation for testing since Chart is abstract
 class TestChart extends Chart {

packages/agent-client/test/domains/collection.test.ts

@@ -1,5 +1,6 @@
+import type HttpRequester from '../../src/http-requester';
+
 import Collection from '../../src/domains/collection';
-import HttpRequester from '../../src/http-requester';
 
 jest.mock('../../src/http-requester');
 jest.mock('../../src/action-fields/field-form-states');