Skip to content

feat: handle rpc relations #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arnaud-moncel wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: handle rpc relations #240

arnaud-moncel wants to merge 8 commits into from

Conversation

@arnaud-moncel
Copy link
Member

@arnaud-moncel arnaud-moncel commented Dec 11, 2025

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 11, 2025 •
edited
Loading

3 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 7): run 2
qlty Structure Function with many parameters (count = 4): add_relation 1

@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from e0bf21c to 863d92f Compare December 11, 2025 17:33
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 863d92f to 12d6546 Compare December 23, 2025 13:39
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 06c3424 to 0a7de88 Compare December 24, 2025 09:53
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 55a26ef to ce5fc5c Compare December 24, 2025 16:08
qltysh[bot]
qltysh bot reviewed Dec 24, 2025
View reviewed changes
packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/reconciliate_rpc.rb
name
end

def add_relation(collection_customizer, renames, relation_name, relation_definition)
Copy link

@qltysh qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): add_relation [qlty:function-parameters]

qltysh[bot]
qltysh bot reviewed Dec 24, 2025
View reviewed changes
packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/reconciliate_rpc.rb
add_relation(cz, options[:rename], relation_name.to_s, relation_definition)
end
end
end
Copy link

@qltysh qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): run [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arnaud-moncel