Skip to content

Conversation

@matthv
Copy link
Member

@matthv matthv commented Dec 23, 2025

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 23, 2025

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.54%.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: F
...er/decorators/rename_collection/rename_collection_decorator.rb36.3%13-16, 20-23, 27-30...
Coverage rating: A Coverage rating: A
...urce_toolkit/schema/relations/polymorphic_one_to_one_schema.rb100.0%
Coverage rating: A Coverage rating: A
...rce_toolkit/schema/relations/polymorphic_one_to_many_schema.rb100.0%
Coverage rating: A Coverage rating: A
...rs/rename_collection/rename_collection_datasource_decorator.rb100.0%
Coverage rating: A Coverage rating: A
...rce_toolkit/schema/relations/polymorphic_many_to_one_schema.rb100.0%
Total40.8%
🤖 Increase coverage with AI coding...

In the `feat/support-polymorphic-rename` branch, add test coverage for this new code:

- `packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb` -- Lines 13-16, 20-23, 27-30, 34-51, 57-67, 71-84, 88-94, 100-101, 106-107, 111-117, and 122-137

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Dec 23, 2025

3 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 8): refine_filter 3

end
end

filter.override(condition_tree: transformed_tree)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 8): refine_filter [qlty:function-complexity]

transformed_data[type_field] = transformed_value if transformed_value != original_value
end

transformed_data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 6): transform_data_polymorphic_values [qlty:function-complexity]

transformed_record[type_field] = new_value if new_value != old_value
end

transformed_record
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): transform_record_polymorphic_values [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants