Skip to content

[HIGH] security(android): clear custom headers between calls #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[HIGH] security(android): clear custom headers between calls #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-ravens-reset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-app-auth": patch
---

Clear Android custom request headers before parsing each call so omitted header groups cannot reuse credentials from an earlier provider.
4 changes: 4 additions & 0 deletions packages/react-native-app-auth/android/src/main/java/com/rnappauth/RNAppAuthModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,10 @@ private void endSessionWithConfiguration(
}

private void parseHeaderMap(ReadableMap headerMap) {
registrationRequestHeaders = null;
authorizationRequestHeaders = null;
tokenRequestHeaders = null;

if (headerMap == null) {
return;
}
Expand Down