Skip to content

Fix undefined behavior from signed left-shift in MSVC-MingW port #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rawalexe merged 1 commit into from
May 6, 2026
+5 −5
Merged

Fix undefined behavior from signed left-shift in MSVC-MingW port #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions portable/MSVC-MingW/port.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ static void prvProcessSimulatedInterrupts( void )

/* Create a pending tick to ensure the first task is started as soon as
* this thread pends. */
ulPendingInterrupts |= ( 1 << portINTERRUPT_TICK );
ulPendingInterrupts |= ( 1UL << portINTERRUPT_TICK );
SetEvent( pvInterruptEvent );

while( xPortRunning == pdTRUE )
Expand Down Expand Up @@ -447,7 +447,7 @@ static void prvProcessSimulatedInterrupts( void )
if( ulIsrHandler[ i ]() != pdFALSE )
{
/* A bit mask is used purely to help debugging. */
ulSwitchRequired |= ( 1 << i );
ulSwitchRequired |= ( 1UL << i );
}
}

Expand Down Expand Up @@ -580,7 +580,7 @@ void vPortCloseRunningThread( void * pvTaskToDelete,
if( pvInterruptEventMutex != NULL )
{
WaitForSingleObject( pvInterruptEventMutex, INFINITE );
ulPendingInterrupts |= ( 1 << portINTERRUPT_YIELD );
ulPendingInterrupts |= ( 1UL << portINTERRUPT_YIELD );
ReleaseMutex( pvInterruptEventMutex );
}

Expand All @@ -604,7 +604,7 @@ void vPortGenerateSimulatedInterrupt( uint32_t ulInterruptNumber )
if( ( ulInterruptNumber < portMAX_INTERRUPTS ) && ( pvInterruptEventMutex != NULL ) )
{
WaitForSingleObject( pvInterruptEventMutex, INFINITE );
ulPendingInterrupts |= ( 1 << ulInterruptNumber );
ulPendingInterrupts |= ( 1UL << ulInterruptNumber );

/* The simulated interrupt is now held pending, but don't actually
* process it yet if this call is within a critical section. It is
Expand Down Expand Up @@ -645,7 +645,7 @@ void vPortGenerateSimulatedInterruptFromWindowsThread( uint32_t ulInterruptNumbe

/* Pending a user defined interrupt to be handled in simulated interrupt
* handler thread. */
ulPendingInterrupts |= ( 1 << ulInterruptNumber );
ulPendingInterrupts |= ( 1UL << ulInterruptNumber );

/* The interrupt is now pending - notify the simulated interrupt
* handler thread. Must be outside of a critical section to get here so
Expand Down
Loading