Skip to content

Fix: Invalidate MPU object pool entry on timer delete in MPU wrappers v2 #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rawalexe wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Fix: Invalidate MPU object pool entry on timer delete in MPU wrappers v2 #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions portable/Common/mpu_wrappers_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3541,6 +3541,15 @@
pxParams->xOptionalValue,
pxParams->pxHigherPriorityTaskWoken,
pxParams->xTicksToWait );

/* Timer deletion is asynchronous - eagerly invalidate the
* object pool entry only if the delete command was successfully
* queued, to prevent stale handle access after the timer daemon
* frees the Timer_t. */
if( ( xReturn == pdPASS ) && ( pxParams->xCommandID == tmrCOMMAND_DELETE ) )
{
MPU_SetIndexFreeInKernelObjectPool( CONVERT_TO_INTERNAL_INDEX( lIndex ) );
}
}
}
}
Expand Down
Loading