Skip to content

chore(deps): override linkify-it to 5.0.2 - #2640

Open
1688mengdie wants to merge 3 commits into
GCWing:mainfrom
BitFun-SIG:chore/security-pnpm-linkify-it
Open

chore(deps): override linkify-it to 5.0.2#2640
1688mengdie wants to merge 3 commits into
GCWing:mainfrom
BitFun-SIG:chore/security-pnpm-linkify-it

Conversation

@1688mengdie

Copy link
Copy Markdown

Summary

pnpm-lock.yaml resolves linkify-it 5.0.0 (through markdown-it), which is
covered by the ReDoS advisories affecting the 5.0.x line below 5.0.2.

This PR adds a workspace-level pnpm override pinning linkify-it to
5.0.2 so markdown-it and every other importer resolve the patched
release.

Fixes #2633

Type and Areas

Type: security fix

Areas: Dependencies (Web UI)

Verification

  • pnpm install --frozen-lockfile — Already up to date, exit 0.
  • pnpm --dir src/web-ui run type-check — exit 0.
  • pnpm --dir src/web-ui run lint — exit 0.
  • vitest Markdown suite incl. link parsing — 14 passed.
  • pnpm run frontend:build-all — exit 0.

Reviewer Notes

  • The override is a new entry in pnpm-workspace.yaml (one line); the
    lockfile diff flips the linkify-it package block/integrity and the
    snapshot references at the markdown-it consumption point (regenerated
    by pnpm install).
  • Rollback is a revert of the two-file change.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable. (Not applicable: no user-facing change.)

This is an AI-assisted change.

user added 3 commits August 29, 2026 08:30
pnpm-lock.yaml pins dompurify 3.3.1, which is affected by the DOM
clobbering XSS advisory GHSA-c2j3-45gr-mqc4 (fixed in 3.4.8) and two low
severity advisories GHSA-vxr8-fq34-vvx9 and GHSA-gvmj-g25r-r7wr.

Add a workspace-level pnpm override pinning dompurify to 3.4.14 and let
pnpm regenerate the lockfile, so every importer resolves the patched
release.

Test: pnpm install --frozen-lockfile (Already up to date, exit 0);
pnpm --dir src/web-ui run type-check (exit 0); pnpm --dir src/web-ui
run lint (exit 0); vitest Markdown suite (14 passed);
pnpm run frontend:build-all (exit 0).
AI: AI-assisted, locally tested (frozen-lockfile resolution + web-ui
checks + full frontend build).
pnpm-lock.yaml resolves lodash-es 4.17.21 and 4.17.23 (two versions
pulled in through chevrotain and mermaid/dagre-d3-es), both covered by
the prototype pollution advisories affecting the 4.17.x line.

Add a workspace-level pnpm override pinning lodash-es to 4.18.1 so the
two 4.17.x releases converge on the patched 4.18.1 across every
importer.

Test: pnpm install --frozen-lockfile (Already up to date, exit 0);
pnpm --dir src/web-ui run type-check (exit 0); pnpm --dir src/web-ui
run lint (exit 0); vitest Markdown + mermaid render suites (14 passed);
pnpm run frontend:build-all (exit 0).
AI: AI-assisted, locally tested (frozen-lockfile resolution + web-ui
checks + full frontend build).
pnpm-lock.yaml resolves linkify-it 5.0.0 (through markdown-it), which is
covered by the ReDoS advisories affecting the 5.0.x line below 5.0.2.

Add a workspace-level pnpm override pinning linkify-it to 5.0.2 so
markdown-it and every other importer resolve the patched release.

Test: pnpm install --frozen-lockfile (Already up to date, exit 0);
pnpm --dir src/web-ui run type-check (exit 0); pnpm --dir src/web-ui
run lint (exit 0); vitest Markdown suite incl. link parsing (14 passed);
pnpm run frontend:build-all (exit 0).
AI: AI-assisted, locally tested (frozen-lockfile resolution + web-ui
checks + full frontend build).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security]: linkify-it 5.0.0 in pnpm-lock.yaml is affected by ReDoS advisories (fixed in 5.0.2)

1 participant