fix(voice): synchronize local model install state - #2763
Merged
wgqqqqq merged 2 commits intoSep 3, 2026
Conversation
wgqqqqq
force-pushed
the
wgq/fix-voice-model-install-state
branch
from
September 3, 2026 07:57
ff016b8 to
410dda9
Compare
Collaborator
Author
|
Fixed the macOS CI failure in Verified on macOS with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyinginstead of leaving the UI atdownloading 100%Root cause
The model payload was moved into its final directory before the install record and required-file hashes were finished.
speech_list_modelscould therefore report the model as installed and enable Use while the active download task still emitteddownloadingat 100%. The composer also retained an unkeyed capability snapshot, so a response for the previous model could overwrite the selected model state.Verification
cargo test -p bitfun-services-integrations --no-default-features --features speech --lib speech::(6 passed)pnpm --dir src/web-ui run test:run src/flow_chat/components/voice/useComposerVoiceInput.test.tsx(7 passed)pnpm run check:webgit diff --checkRemote scenarios
Exercised on the local Desktop/service path. Remote Workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not runtime-tested; the service-side state transition remains platform-neutral and does not change the transport contract.
AI-assisted change; fully tested with the focused checks above.