fix(settings): refine model provider editing, testing, and deletion - #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: N/A
Type and Areas
Type:
Bug fix / regression fix / UI/UX / test
Areas:
Web UI — model settings, configuration state, Peer Device capability handling, and i18n.
Motivation / Impact
The model provider configuration workflow had several related usability and efficiency issues:
This PR makes provider editing recoverable, reduces unnecessary model requests, adds direct provider deletion, and repairs the advanced-settings layout.
Verification
pnpm run check:webpnpm --dir src/web-ui run test:run src/infrastructure/config/components/modelConnectionTestPlan.test.ts src/infrastructure/config/services/modelConfigs.test.ts src/infrastructure/config/components/ModelSettingsDialog.presentation.test.ts src/infrastructure/config/components/ModelSettingsPage.presentation.test.ts src/infrastructure/config/components/ModelServiceCollapse.presentation.test.tspnpm run i18n:auditReviewer Notes
ai.modelsupdate path and removes every model associated with the selected provider group.debug-agent.logwere removed before submission.Checklist