Move printable types out of printers#601
Open
ChrisJChang wants to merge 1 commit into
Open
Conversation
…ed observables for printable versions of:" This reverts commit 5c5b618.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_printable_types.zip
Note: I accidentally pushed directly to master, so I reverted it, and reapplied it for this PR. Hence why the only commit is a reapply of an existing commit. Our branch protections for master let any repo admin bypass it, but since that is everyone, we effectively had no branch protections. I have now updated those.
This PR moves several printable types out of the Printer module, into their own module. It does this by creating additional observables with the name printable_blah (e.g. printable_primordial_abundances_BBN). If this is specified in the yaml (in the ObsLike section), it will use the version that has already been translated into a printable type like map_str_double.
It does create a bunch of new capabilities for the different flav predictions, so perhaps that is not optimal
I have attached a yaml file that I used to test this for the Cosmo case.