Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0#4729
Open
seisman wants to merge 4 commits into
Open
Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0#4729seisman wants to merge 4 commits into
seisman wants to merge 4 commits into
Conversation
…upcoming GMT 6.7.0
seisman
added
bug
…ty with upcoming GMT 6.7.0" This reverts commit 6ab0ecb.
…upcoming GMT 6.7.0
Member
|
Hmm, as this is related to the upcoming GMT 6.7.0 version, is this a bug or a breaking change for PyGMT? |
Member
Author
|
It's a bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in the GMT Dev Tests (https://github.com/GenericMappingTools/pygmt/actions/runs/29382671247/job/87249463921), calling
Figure.directional_rose()andFigure.magnetic_rose()without any arguments don't work for GMT 6.7.0.This is because for GMT 6.7.0, we set the default position to
None, but in PyGMT, it means the-Tdoption is not specified, but actually we need-Td. We can either setdefault=Trueor simply always set thepositionparameter. This PR takes the 2nd option.Patches #4702.