feat(ui): remove composer#114
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR removes core message composer components ( ChangesMessage Composer Components Removal
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/stream_core_flutter/CHANGELOG.md`:
- Around line 31-34: Update the breaking-change bullet to clarify this rename
applies to the moved types in the other package, not inside stream_core_flutter:
change the wording that currently says "Renamed `inputBody` to `inputCenter` on
`StreamCoreMessageComposer` and `StreamMessageComposerInput`" to explicitly
scope it (for example, "In `stream_chat_flutter`: renamed `inputBody` to
`inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`")
and mention that these types were moved out of this package to avoid confusing
stream_core_flutter consumers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 159c9424-d333-415a-a107-777b66a977be
📒 Files selected for processing (7)
apps/design_system_gallery/lib/app/gallery_app.directories.g.dartapps/design_system_gallery/lib/components/message_composer/message_composer.dartpackages/stream_core_flutter/CHANGELOG.mdpackages/stream_core_flutter/lib/src/components/message_composer.dartpackages/stream_core_flutter/lib/src/components/message_composer/message_composer.dartpackages/stream_core_flutter/lib/src/components/message_composer/message_composer_input.dartpackages/stream_core_flutter/lib/src/components/message_composer/message_composer_input_trailing.dart
💤 Files with no reviewable changes (6)
- apps/design_system_gallery/lib/components/message_composer/message_composer.dart
- packages/stream_core_flutter/lib/src/components/message_composer/message_composer_input_trailing.dart
- packages/stream_core_flutter/lib/src/components/message_composer/message_composer.dart
- packages/stream_core_flutter/lib/src/components/message_composer/message_composer_input.dart
- apps/design_system_gallery/lib/app/gallery_app.directories.g.dart
- packages/stream_core_flutter/lib/src/components/message_composer.dart
| ### ⚠️ Breaking Changes | ||
|
|
||
| - Renamed `inputBody` to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`. | ||
|
|
There was a problem hiding this comment.
Clarify rename note for types removed from this package.
This entry currently reads like an in-package API rename, but those types are documented as moved out earlier. Please scope this rename to migration guidance (e.g., “in stream_chat_flutter”) to avoid confusion for stream_core_flutter consumers.
Suggested changelog wording
-### ⚠️ Breaking Changes
-
-- Renamed `inputBody` to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`.
+### ⚠️ Migration Notes
+
+- In `stream_chat_flutter`, `inputBody` was renamed to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### ⚠️ Breaking Changes | |
| - Renamed `inputBody` to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`. | |
| ### ⚠️ Migration Notes | |
| - In `stream_chat_flutter`, `inputBody` was renamed to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/stream_core_flutter/CHANGELOG.md` around lines 31 - 34, Update the
breaking-change bullet to clarify this rename applies to the moved types in the
other package, not inside stream_core_flutter: change the wording that currently
says "Renamed `inputBody` to `inputCenter` on `StreamCoreMessageComposer` and
`StreamMessageComposerInput`" to explicitly scope it (for example, "In
`stream_chat_flutter`: renamed `inputBody` to `inputCenter` on
`StreamCoreMessageComposer` and `StreamMessageComposerInput`") and mention that
these types were moved out of this package to avoid confusing
stream_core_flutter consumers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 33.04% 33.78% +0.74%
==========================================
Files 171 168 -3
Lines 6595 6450 -145
==========================================
Hits 2179 2179
+ Misses 4416 4271 -145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ### ⚠️ Breaking Changes | ||
|
|
||
| - Renamed `inputBody` to `inputCenter` on `StreamCoreMessageComposer` and `StreamMessageComposerInput`. | ||
|
|
There was a problem hiding this comment.
We should remove this file to be consistent with other components. lets directly reference all the attachments in the root file.
- Remove stale breaking-change entry for inputBody→inputCenter rename (types moved out of this package) - Remove intermediate message_composer.dart barrel file; inline attachment exports directly in components.dart Co-authored-by: Cursor <cursoragent@cursor.com>
Submit a pull request
CLA
Description of the pull request
This moves all the composer parts to chat, as they are not really re-usable anyway and only confusing.
Related to: GetStream/stream-chat-flutter#2642
Summary by CodeRabbit