test(node): add missing owner_did field to fails-closed seed update#229
Conversation
PRs #113 and #145 raced: #145 added owner_did to ReceivedRefUpdate and updated its own call sites, but the seed initializer in list_repo_events_fails_closed_when_repo_lookup_errors (added by #113) was never updated, so main fails to compile test targets (E0063). This breaks clippy --all-targets, both test jobs, and MSRV on CI, including the release PR #182. owner_did stays None here on purpose: the test exercises the legacy None-branch slug fallback.
|
Thanks for the contribution. A couple of things will help us review this faster:
See CONTRIBUTING.md. Update the PR and these notes will clear automatically. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe repository event failure test now explicitly sets ChangesRef-update failure test
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…229) PRs #113 and #145 raced: #145 added owner_did to ReceivedRefUpdate and updated its own call sites, but the seed initializer in list_repo_events_fails_closed_when_repo_lookup_errors (added by #113) was never updated, so main fails to compile test targets (E0063). This breaks clippy --all-targets, both test jobs, and MSRV on CI, including the release PR #182. owner_did stays None here on purpose: the test exercises the legacy None-branch slug fallback. Co-authored-by: Kevin Codex <kevin@gitlawb.com>
Summary
Adds the
owner_didfield missing from oneReceivedRefUpdatetest initializer, unbreaking compilation of test targets on main (and CI on release PR #182).Motivation & context
#113 and #145 raced: #145 added
owner_didtoReceivedRefUpdateand updated its own call sites, but the seed initializer inlist_repo_events_fails_closed_when_repo_lookup_errors(added by #113) predates it. Merged main failsclippy --all-targets,cargo test, and MSRV with E0063;build --releasepasses, which is why this slipped through. Blocks #182.Kind of change
What changed
gitlawb-node: setowner_did: Nonein the fails-closed test's seed update — None on purpose, the test exercises the legacy None-branch slug fallback.How a reviewer can verify