feat(lib): introduce canonical types for feature comparison #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
approved these changes
Dec 26, 2025
Defines a new package `lib/workertypes/comparables` to hold the canonical, internal data structures used for diffing. These structs are decoupled from any specific storage (blob) version. The `differ` will use these types as its core data model, and adapters will be responsible for converting versioned blob types to and from these canonical types. Part of #2107 Split up of #2106
jcscottiii
force-pushed
the
jcscottiii/canonical-diff-types
branch
from
68b48ea to
a13eeb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a new package
lib/workertypes/comparablesto hold the canonical, internal data structures used for diffing.These structs are decoupled from any specific storage (blob) version. The
differwill use these types as its core data model, and adapters will be responsible for converting versioned blob types to and from these canonical types.Part of #2107
Split up of #2106