-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add httpFilters field to targethttpproxy resource #16037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1318 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| - name: 'httpFilters' | ||
| type: Array | ||
| description: | | ||
| URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration. | |
| URLs to **networkservices.HttpFilter** resources enabled for xDS clients using this configuration. |
| description: | | ||
| URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration. | ||
| This field only applies when the forwarding rule that references this target proxy has a | ||
| loadBalancingScheme set to INTERNAL_SELF_MANAGED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| loadBalancingScheme set to INTERNAL_SELF_MANAGED. | |
| **loadBalancingScheme** set to INTERNAL_SELF_MANAGED. |
| URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration. | ||
| This field only applies when the forwarding rule that references this target proxy has a | ||
| loadBalancingScheme set to INTERNAL_SELF_MANAGED. | ||
| api_name: httpFilters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is api_name needed?
This pr adds HttpFilters to TargetHttpProxy