Skip to content

Conversation

@Dawid212
Copy link
Contributor

This pr adds HttpFilters to TargetHttpProxy

compute: add `http_filters` field to `google_compute_target_http_proxy` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 29, 2025
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 December 29, 2025 00:06
@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+))
google-beta provider: Diff ( 4 files changed, 105 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1318
Passed tests: 1233
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

- name: 'httpFilters'
type: Array
description: |
URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration.
URLs to **networkservices.HttpFilter** resources enabled for xDS clients using this configuration.

description: |
URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration.
This field only applies when the forwarding rule that references this target proxy has a
loadBalancingScheme set to INTERNAL_SELF_MANAGED.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loadBalancingScheme set to INTERNAL_SELF_MANAGED.
**loadBalancingScheme** set to INTERNAL_SELF_MANAGED.

URLs to networkservices.HttpFilter resources enabled for xDS clients using this configuration.
This field only applies when the forwarding rule that references this target proxy has a
loadBalancingScheme set to INTERNAL_SELF_MANAGED.
api_name: httpFilters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is api_name needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants