Skip to content

Fix TestAccComputeInstance_advancedMachineFeatures failure due to capacity#18380

Draft
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:bugfix-535844294-TestAccComputeInstance_advancedMachineFeatures
Draft

Fix TestAccComputeInstance_advancedMachineFeatures failure due to capacity#18380
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:bugfix-535844294-TestAccComputeInstance_advancedMachineFeatures

Conversation

@nsamartsev

@nsamartsev nsamartsev commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bug: Fix TestAccComputeInstance_advancedMachineFeatures failure due to capacity. Changed the hardcoded zone from `us-central1-a` to `us-central1-c` in `c4-standard-2` machine type tests for compute instances, container clusters, and node pools. Fixes hashicorp/terraform-provider-google#28372.

@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 30d2027:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 19 insertions(+), 19 deletions(-)
google-beta provider View Diff 3 files changed, 19 insertions(+), 19 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1871 1749 109 13
Affected Service Packages
  • compute
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstance_advancedMachineFeatures
  • TestAccComputeInstance_performanceMonitoringUnit
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Architectural
  • TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
  • TestAccContainerCluster_withKubeletConfig
  • TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
  • TestAccContainerCluster_withKubeletResourceManagerConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstance_performanceMonitoringUnit
✅ Log TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Architectural
✅ Log TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
✅ Log TestAccContainerCluster_withKubeletConfig
✅ Log TestAccContainerCluster_withKubeletConfigShutdownGracePeriod
✅ Log TestAccContainerCluster_withKubeletResourceManagerConfig
✅ Log TestAccContainerNodePool_withKubeletConfig
✅ Log TestAccContainerNodePool_withKubeletConfigShutdownGracePeriod
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstance_advancedMachineFeatures
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 30d2027!

@nsamartsev
nsamartsev force-pushed the bugfix-535844294-TestAccComputeInstance_advancedMachineFeatures branch from 30d2027 to 0852c57 Compare July 24, 2026 09:05
@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0852c57:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 6 insertions(+), 6 deletions(-)
google-beta provider View Diff 1 file changed, 6 insertions(+), 6 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1453 95 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstance_advancedMachineFeatures
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstance_advancedMachineFeatures
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 0852c57!

…acity

Changed the hardcoded zone to `us-central1-b` in `c4-standard-2` machine type tests for compute instances. This resolves the recent 403 / capacity stockout errors when running these tests in the nightly CI.

Fixes hashicorp/terraform-provider-google#28372
@nsamartsev
nsamartsev force-pushed the bugfix-535844294-TestAccComputeInstance_advancedMachineFeatures branch from 0852c57 to 8332e13 Compare July 24, 2026 12:05
@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8332e13:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 6 insertions(+), 6 deletions(-)
google-beta provider View Diff 1 file changed, 6 insertions(+), 6 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1452 95 4
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstance_advancedMachineFeatures
  • TestAccComputeInstance_performanceMonitoringUnit
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstance_advancedMachineFeatures
✅ Log TestAccComputeInstance_performanceMonitoringUnit
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 8332e13!

This fixes an issue where updating rule attributes like 'match', 'action', or 'description' simultaneously with 'preconfigured_waf_config' would result in those attributes being silently ignored or causing backend validation errors. We now properly append them to the patchRuleUpdateMask if they have changed.
@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff80c06:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 26 insertions(+), 6 deletions(-)
google-beta provider View Diff 2 files changed, 26 insertions(+), 6 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1447 95 9
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_EnforceOnKeyUpdates
  • TestAccComputeSecurityPolicy_inlineRuleUpdate
  • TestAccComputeSecurityPolicy_modifyExprOptions
  • TestAccComputeSecurityPolicy_ruleActionUpdate
  • TestAccComputeSecurityPolicy_update
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccComputeSecurityPolicy_withRateLimitOption_withMultipleEnforceOnKeyConfigs
  • TestAccComputeSecurityPolicy_withRedirectOptionsUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeSecurityPolicy_EnforceOnKeyUpdates
✅ Log TestAccComputeSecurityPolicy_inlineRuleUpdate
✅ Log TestAccComputeSecurityPolicy_modifyExprOptions
✅ Log TestAccComputeSecurityPolicy_ruleActionUpdate
✅ Log TestAccComputeSecurityPolicy_update
✅ Log TestAccComputeSecurityPolicy_withRateLimitOption_withMultipleEnforceOnKeyConfigs
✅ Log TestAccComputeSecurityPolicy_withRedirectOptionsUpdate
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for ff80c06!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants