Skip to content

compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP [advanced]#18384

Open
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-compute-scheduling-ga-panic
Open

compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP [advanced]#18384
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-compute-scheduling-ga-panic

Conversation

@shuyama1

Copy link
Copy Markdown
Member

Wrap beta-only scheduling fields (skip_guest_os_shutdown and preemption_notice_duration) within {{- if ne $.TargetVersionName "ga" }} guards in FlattenSchedulingHTTP.

Previously, FlattenSchedulingHTTP unconditionally set skip_guest_os_shutdown and preemption_notice_duration in schedulingMap, causing a panic in GA provider read/create functions because these fields do not exist in the GA schema.

compute: fixed panic when setting scheduling fields in `google_compute_region_instance_template` GA provider

@shuyama1 shuyama1 changed the title compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP [advanced] Jul 24, 2026
@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f278549:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 12 deletions(-)
google-beta provider View Diff 1 file changed, 1 deletion(-)
terraform-google-conversion View Diff 2 files changed, 13 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1551 1454 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shuyama1 VCR tests complete for f278549!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants