compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP [advanced]#18384
compute: wrap beta-only scheduling fields in FlattenSchedulingHTTP [advanced]#18384shuyama1 wants to merge 1 commit into
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f278549: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
Wrap beta-only scheduling fields (
skip_guest_os_shutdownandpreemption_notice_duration) within{{- if ne $.TargetVersionName "ga" }}guards inFlattenSchedulingHTTP.Previously,
FlattenSchedulingHTTPunconditionally setskip_guest_os_shutdownandpreemption_notice_durationinschedulingMap, causing a panic in GA provider read/create functions because these fields do not exist in the GA schema.