memorystore: document TOKEN_AUTH as a google-beta-only authorization_mode value#18387
Open
abdalazizmoh wants to merge 1 commit into
Open
memorystore: document TOKEN_AUTH as a google-beta-only authorization_mode value#18387abdalazizmoh wants to merge 1 commit into
abdalazizmoh wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…mode value for google_memorystore_instance
abdalazizmoh
force-pushed
the
memorystore-instance-token-auth
branch
from
July 24, 2026 14:09
881cb58 to
37b1b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#27309.
authorization_modeongoogle_memorystore_instancehas no client-side enum validation, so this is a documentation-only change to the field's description.I verified
TOKEN_AUTHis currently only accepted by the beta (v1beta) API surface, not GA (v1):gcloud memorystore instances create --authorization-mode=token-auth(GA track) is rejected client-side:Invalid choice: 'token-auth'. Valid choices are [auth-disabled, iam-auth].gcloud beta memorystore instances create --authorization-mode=token-auth(beta track) passes both client-side and server-side validation — a real create request against a test project got all the way to a running operation and only failed on an unrelated (intentionally invalid) network field.So the description now notes
TOKEN_AUTHis only available via thegoogle-betaprovider, matching the existing convention for beta-only capabilities documented on otherwise-GA fields (e.g.compute/BackendService.yaml's "Currently self-managed internal load balancing is only available in beta.").