Skip to content

Adding in google_memorystore_auth_token, google_memorystore_token_auth_user, google_memorystore_auth_token and google_redis_token_auth_user with corresponding datasources #18395

Draft
NA2047 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
NA2047:tokenAuthMemRed
Draft

Adding in google_memorystore_auth_token, google_memorystore_token_auth_user, google_memorystore_auth_token and google_redis_token_auth_user with corresponding datasources #18395
NA2047 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
NA2047:tokenAuthMemRed

Conversation

@NA2047

@NA2047 NA2047 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_redis_auth_token`
`google_redis_token_auth_user`
`google_memorystore_auth_token`
`google_memorystore_token_auth_user`
`google_memorystore_token_auth_user`
`google_memorystore_auth_token`
`google_redis_auth_token`
`google_redis_token_auth_user`

@github-actions
github-actions Bot requested a review from rileykarson July 24, 2026 21:14
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 033bff8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 30 files changed, 4022 insertions(+), 3 deletions(-)
google-beta provider View Diff 30 files changed, 4022 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 5 files changed, 486 insertions(+), 2 deletions(-)
Open in Cloud Shell View Diff 12 files changed, 366 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_token_auth_user (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_token_auth_user" "primary" {
  region = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_redis_auth_token
  • google_redis_token_auth_user

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_memorystore_auth_token, google_memorystore_token_auth_user, google_redis_auth_token, google_redis_token_auth_user. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Missing doc report (experimental)

The following data sources are missing documents:

  • google_memorystore_auth_token, expect file /website/docs/d/memorystore_auth_token.html.markdown to exist.
  • google_memorystore_token_auth_user, expect file /website/docs/d/memorystore_token_auth_user.html.markdown to exist.
  • google_redis_auth_token, expect file /website/docs/d/redis_auth_token.html.markdown to exist.
  • google_redis_token_auth_user, expect file /website/docs/d/redis_token_auth_user.html.markdown to exist.

Test report

Analytics

Total Tests Passed Skipped Affected
76 64 0 12
Affected Service Packages
  • redis
  • memorystore

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMemorystoreAuthTokenDatasource
  • TestAccMemorystoreAuthToken_basic
  • TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
  • TestAccMemorystoreTokenAuthUserDatasource
  • TestAccMemorystoreTokenAuthUser_basic
  • TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
  • TestAccRedisAuthTokenDatasource
  • TestAccRedisAuthToken_basic
  • TestAccRedisAuthToken_redisAuthTokenBasicExample
  • TestAccRedisTokenAuthUserDatasource
  • TestAccRedisTokenAuthUser_basic
  • TestAccRedisTokenAuthUser_redisAuthTokenBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMemorystoreTokenAuthUserDatasource
❌ Error · Log - TestAccMemorystoreAuthTokenDatasource
❌ Error · Log - TestAccMemorystoreAuthToken_basic
❌ Error · Log - TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
❌ Error · Log - TestAccMemorystoreTokenAuthUser_basic
❌ Error · Log - TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
❌ Error · Log - TestAccRedisAuthTokenDatasource
❌ Error · Log - TestAccRedisAuthToken_basic
❌ Error · Log - TestAccRedisAuthToken_redisAuthTokenBasicExample
❌ Error · Log - TestAccRedisTokenAuthUserDatasource
❌ Error · Log - TestAccRedisTokenAuthUser_basic
❌ Error · Log - TestAccRedisTokenAuthUser_redisAuthTokenBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @rileykarson VCR tests complete for 033bff8!

@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d55038:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 34 files changed, 4240 insertions(+), 3 deletions(-)
google-beta provider View Diff 34 files changed, 4240 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 5 files changed, 486 insertions(+), 2 deletions(-)
Open in Cloud Shell View Diff 12 files changed, 366 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster_token_auth_user (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_token_auth_user" "primary" {
  region = # value needed
}

Multiple resources added

This PR adds multiple new resources: google_memorystore_auth_token, google_memorystore_token_auth_user, google_redis_cluster_auth_token, google_redis_cluster_token_auth_user. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
76 65 0 11
Affected Service Packages
  • redis
  • memorystore

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMemorystoreAuthTokenDatasource
  • TestAccMemorystoreAuthToken_basic
  • TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
  • TestAccMemorystoreTokenAuthUser_basic
  • TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
  • TestAccRedisClusterAuthTokenDatasource
  • TestAccRedisClusterAuthToken_basic
  • TestAccRedisClusterAuthToken_redisAuthTokenBasicExample
  • TestAccRedisClusterTokenAuthUserDatasource
  • TestAccRedisClusterTokenAuthUser_basic
  • TestAccRedisClusterTokenAuthUser_redisAuthTokenBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccMemorystoreAuthTokenDatasource
❌ Error · Log - TestAccMemorystoreAuthToken_basic
❌ Error · Log - TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
❌ Error · Log - TestAccMemorystoreTokenAuthUser_basic
❌ Error · Log - TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
❌ Error · Log - TestAccRedisClusterAuthTokenDatasource
❌ Error · Log - TestAccRedisClusterAuthToken_basic
❌ Error · Log - TestAccRedisClusterAuthToken_redisAuthTokenBasicExample
❌ Error · Log - TestAccRedisClusterTokenAuthUserDatasource
❌ Error · Log - TestAccRedisClusterTokenAuthUser_basic
❌ Error · Log - TestAccRedisClusterTokenAuthUser_redisAuthTokenBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @rileykarson VCR tests complete for 5d55038!

@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f191029:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 34 files changed, 4238 insertions(+), 3 deletions(-)
google-beta provider View Diff 34 files changed, 4238 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 5 files changed, 486 insertions(+), 2 deletions(-)
Open in Cloud Shell View Diff 12 files changed, 366 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster_token_auth_user (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_token_auth_user" "primary" {
  region = # value needed
}

Multiple resources added

This PR adds multiple new resources: google_memorystore_auth_token, google_memorystore_token_auth_user, google_redis_cluster_auth_token, google_redis_cluster_token_auth_user. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
76 65 0 11
Affected Service Packages
  • memorystore
  • redis

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMemorystoreAuthTokenDatasource
  • TestAccMemorystoreAuthToken_basic
  • TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
  • TestAccMemorystoreTokenAuthUser_basic
  • TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
  • TestAccRedisClusterAuthTokenDatasource
  • TestAccRedisClusterAuthToken_basic
  • TestAccRedisClusterAuthToken_redisAuthTokenBasicExample
  • TestAccRedisClusterTokenAuthUserDatasource
  • TestAccRedisClusterTokenAuthUser_basic
  • TestAccRedisClusterTokenAuthUser_redisAuthTokenBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccMemorystoreAuthTokenDatasource
❌ Error · Log - TestAccMemorystoreAuthToken_basic
❌ Error · Log - TestAccMemorystoreAuthToken_memorystoreAuthTokenBasicExample
❌ Error · Log - TestAccMemorystoreTokenAuthUser_basic
❌ Error · Log - TestAccMemorystoreTokenAuthUser_memorystoreTokenAuthUserBasicExample
❌ Error · Log - TestAccRedisClusterAuthTokenDatasource
❌ Error · Log - TestAccRedisClusterAuthToken_basic
❌ Error · Log - TestAccRedisClusterAuthToken_redisAuthTokenBasicExample
❌ Error · Log - TestAccRedisClusterTokenAuthUserDatasource
❌ Error · Log - TestAccRedisClusterTokenAuthUser_basic
❌ Error · Log - TestAccRedisClusterTokenAuthUser_redisAuthTokenBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @rileykarson VCR tests complete for f191029!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants