Skip to content

Add Sandbox launcher to Cloud run service - #18396

Open
yanweiguo wants to merge 17 commits into
GoogleCloudPlatform:mainfrom
yanweiguo:sandbox_launcher
Open

Add Sandbox launcher to Cloud run service#18396
yanweiguo wants to merge 17 commits into
GoogleCloudPlatform:mainfrom
yanweiguo:sandbox_launcher

Conversation

@yanweiguo

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv: added `sandbox_launcher` field to the containers of  `google_cloud_run_service` resource
cloudrunv2: added `sandbox_launcher` field to the containers of  `google_cloud_run_v2_service` resource

@github-actions
github-actions Bot requested a review from SirGitsalot July 24, 2026 21:41
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cd8fa35:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 181 insertions(+), 28 deletions(-)
google-beta provider View Diff 7 files changed, 182 insertions(+), 29 deletions(-)
terraform-google-conversion View Diff 2 files changed, 22 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (79 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  template {
    containers {
      sandbox_launcher = # value needed
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
132 114 17 1
Affected Service Packages
  • cloudrun
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceSandboxExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCloudRunService_cloudRunServiceSandboxExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@yanweiguo, @rafaeltello, @SirGitsalot VCR tests complete for cd8fa35!

@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 10e10d5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 237 insertions(+), 28 deletions(-)
google-beta provider View Diff 8 files changed, 238 insertions(+), 29 deletions(-)
terraform-google-conversion View Diff 2 files changed, 22 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 113 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
133 115 17 1
Affected Service Packages
  • cloudrun
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceSandboxExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCloudRunV2Service_cloudrunv2ServiceSandboxExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@yanweiguo, @SirGitsalot VCR tests complete for 10e10d5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants