Conversation
|
@soullivaneuh you can see what I've done here: https://github.com/Hast/Image/commit/38cb28a1b8ab645ba1ff0bfa3feb4382bc848efc |
|
Ok thanks, will take a look. |
|
@Gregwar Integrate Imagick adapter is a little bit complicated as the functions and parameters are often differents. Imagine already do that: http://imagine.readthedocs.org/en/latest/ I'm not sure if it's a good idea to integrate it on Image or ImageBundle directly, but this, integrated on symfony, could be very simplier. What is your think? Thanks. |
|
Hi @soullivaneuh The demo files are only here to test quickly some case by hand, and to show some examples. I personally run them manually. Tests are based on phpunit, It could be adapted to be run for both GD and Imagick if you want. What kind of failure are you mentioning? |
Refer to #34, I started a PR for Imagick implementation.
@hast and @nick4fake, please tell me if you already start to work on it!
Here my TODO list:
Imagickadapter classImagickadapter classPlease tell me if you think I missed some points on TODO list.
Some questions for @Gregwar:
I will work on it some evenings and weekends, hope to finish that quickly.
Thanks.