Support for configuring adapter#98
Open
kriswillis wants to merge 3 commits intoGregwar:masterfrom
kriswillis:adapter-config
Open
Support for configuring adapter#98kriswillis wants to merge 3 commits intoGregwar:masterfrom kriswillis:adapter-config
kriswillis wants to merge 3 commits intoGregwar:masterfrom
kriswillis:adapter-config
Conversation
soullivaneuh
requested changes
Jan 6, 2017
| ->booleanNode('throw_exception')->defaultFalse()->end() | ||
| ->scalarNode('fallback_image')->defaultNull()->end() | ||
| ->scalarNode('web_dir')->defaultValue('%kernel.root_dir%/../web')->end() | ||
| ->scalarNode('adapter')->defaultValue('gd')->end() |
Collaborator
There was a problem hiding this comment.
This is not a class name and will not work.
I think it would be better to create services of adapters and configure the service name instead.
BTW, maybe can you write some tests using this library? https://packagist.org/packages/matthiasnoback/symfony-dependency-injection-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a custom adapter is written, there was no way to configure the bundle to use it; this pull request adds this functionality.