feat!: migrate Employee.Profile to hook architecture and add steady-state edit mode #1674
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .container { | ||
| width: 100%; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| import { useState } from 'react' | ||
| import { useTranslation } from 'react-i18next' | ||
| import classNames from 'classnames' | ||
| import { useEmployeeDetailsForm } from '../shared/useEmployeeDetailsForm' | ||
| import styles from './Profile.module.scss' | ||
| import { | ||
| BaseBoundaries, | ||
| BaseLayout, | ||
| type BaseComponentInterface, | ||
| type CommonComponentInterface, | ||
| } from '@/components/Base' | ||
| import { ActionsLayout } from '@/components/Common' | ||
| import { Form } from '@/components/Common/Form' | ||
| import { Grid } from '@/components/Common/Grid/Grid' | ||
| import { SDKFormProvider } from '@/partner-hook-utils/form/SDKFormProvider' | ||
| import { useI18n, useComponentDictionary } from '@/i18n' | ||
| import { componentEvents } from '@/shared/constants' | ||
| import { useComponentContext } from '@/contexts/ComponentAdapter/useComponentContext' | ||
|
|
||
| export interface ProfileProps extends CommonComponentInterface<'Employee.Profile'> { | ||
| employeeId: string | ||
| onEvent: BaseComponentInterface['onEvent'] | ||
| } | ||
|
|
||
| export function Profile({ | ||
| FallbackComponent, | ||
| ...props | ||
| }: ProfileProps & Pick<BaseComponentInterface, 'FallbackComponent'>) { | ||
| return ( | ||
| <BaseBoundaries componentName="Employee.Profile" FallbackComponent={FallbackComponent}> | ||
| <ProfileRoot {...props} /> | ||
| </BaseBoundaries> | ||
| ) | ||
| } | ||
|
|
||
| function ProfileRoot({ employeeId, className, dictionary, onEvent }: ProfileProps) { | ||
| useI18n('Employee.Profile') | ||
| useComponentDictionary('Employee.Profile', dictionary) | ||
| const { t } = useTranslation('Employee.Profile') | ||
| const Components = useComponentContext() | ||
|
|
||
| const employeeDetails = useEmployeeDetailsForm({ | ||
| employeeId, | ||
| withSelfOnboardingField: false, | ||
| optionalFieldsToRequire: { | ||
| update: ['firstName', 'lastName', 'email', 'dateOfBirth', 'ssn'], | ||
| }, | ||
| }) | ||
|
dmortal marked this conversation as resolved.
|
||
|
|
||
| const [showSuccess, setShowSuccess] = useState(false) | ||
|
|
||
| if (employeeDetails.isLoading) { | ||
| return <BaseLayout isLoading error={employeeDetails.errorHandling.errors} /> | ||
| } | ||
|
|
||
| const Fields = employeeDetails.form.Fields | ||
|
|
||
| const handleSubmit = async () => { | ||
| setShowSuccess(false) | ||
| const result = await employeeDetails.actions.onSubmit({ | ||
| onEmployeeUpdated: emp => { | ||
| onEvent(componentEvents.EMPLOYEE_UPDATED, emp) | ||
| }, | ||
| }) | ||
| if (!result) return | ||
| setShowSuccess(true) | ||
| } | ||
|
|
||
| const handleCancel = () => { | ||
| onEvent(componentEvents.CANCEL) | ||
| } | ||
|
|
||
| const alert = showSuccess ? ( | ||
| <Components.Alert | ||
| status="success" | ||
| label={t('successAlert')} | ||
| onDismiss={() => { | ||
| setShowSuccess(false) | ||
| }} | ||
| /> | ||
| ) : undefined | ||
|
|
||
| return ( | ||
| <section className={classNames(styles.container, className)}> | ||
| <BaseLayout error={employeeDetails.errorHandling.errors}> | ||
| <SDKFormProvider formHookResult={employeeDetails}> | ||
| <Form onSubmit={handleSubmit}> | ||
| {alert} | ||
| <Components.Heading as="h1">{t('title')}</Components.Heading> | ||
| <Grid | ||
| gap={{ base: 20, small: 8 }} | ||
| gridTemplateColumns={{ base: '1fr', small: ['1fr', 200] }} | ||
| > | ||
| <Fields.FirstName | ||
| label={t('firstName')} | ||
| validationMessages={{ | ||
| REQUIRED: t('validations.firstName'), | ||
| INVALID_NAME: t('validations.firstName'), | ||
| }} | ||
| /> | ||
| <Fields.MiddleInitial label={t('middleInitial')} /> | ||
| </Grid> | ||
| <Fields.LastName | ||
| label={t('lastName')} | ||
| validationMessages={{ | ||
| REQUIRED: t('validations.lastName'), | ||
| INVALID_NAME: t('validations.lastName'), | ||
| }} | ||
| /> | ||
| <Fields.Email | ||
| label={t('email')} | ||
| description={t('emailDescription')} | ||
| validationMessages={{ | ||
| REQUIRED: t('validations.email'), | ||
| INVALID_EMAIL: t('validations.email'), | ||
| EMAIL_REQUIRED_FOR_SELF_ONBOARDING: t('validations.email'), | ||
| }} | ||
| /> | ||
| <Fields.Ssn | ||
| label={t('ssnLabel')} | ||
| validationMessages={{ | ||
| INVALID_SSN: t('validations.ssn', { ns: 'common' }), | ||
| REQUIRED: t('validations.ssnRequired', { ns: 'common' }), | ||
| }} | ||
| /> | ||
| <Fields.DateOfBirth | ||
| label={t('dobLabel')} | ||
| validationMessages={{ REQUIRED: t('validations.dob', { ns: 'common' }) }} | ||
| /> | ||
| <ActionsLayout> | ||
| <Components.Button variant="secondary" onClick={handleCancel}> | ||
| {t('cancelCta')} | ||
| </Components.Button> | ||
| <Components.Button type="submit" isLoading={employeeDetails.status.isPending}> | ||
| {t('saveCta')} | ||
| </Components.Button> | ||
| </ActionsLayout> | ||
| </Form> | ||
| </SDKFormProvider> | ||
| </BaseLayout> | ||
| </section> | ||
| ) | ||
| } | ||
|
Comment on lines
+1
to
+143
There was a problem hiding this comment. 🟠 Major | New management Profile component (143 lines) has no test file. The analogous FederalTaxes/management/FederalTaxes.test.tsx covers rendering, form validation, cancel/save flows, and event emissions (CANCEL, EMPLOYEE_FEDERAL_TAXES_UPDATED). This component has similar testable behaviors: form rendering, handleSubmit with success alert, handleCancel emitting CANCEL event, loading state, and error handling — all untested. |
||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.