fix: prevent details card width reduction on unlimited time-off policies only#1686
Merged
jeffredodd merged 2 commits intomainfrom May 6, 2026
Merged
fix: prevent details card width reduction on unlimited time-off policies only#1686jeffredodd merged 2 commits intomainfrom
jeffredodd merged 2 commits intomainfrom
Conversation
jeffredodd
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the TimeOff policy details view styling so the “Details” card doesn’t shrink to a tiny width when rendered with sparse content (notably for unlimited policies).
Changes:
- Add
min-width: toRem(320)to theTimeOffPolicyDetail.descriptionCardwrapper while keepingmax-width: toRem(480).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
4
| .descriptionCard { | ||
| min-width: toRem(320); | ||
| max-width: toRem(480); | ||
| } |
jeffredodd
force-pushed
the
fix/details-card-min-width
branch
from
0436a8e to
3b682ec
Compare
jeffredodd
added a commit
that referenced
this pull request
May 6, 2026
Apply min-width: 320px only on the Details card when accrualMethod is 'unlimited', leaving limited-policy Details and Settings cards unaffected. Addresses Copilot review feedback on PR #1686. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
krisxcrash
approved these changes
May 6, 2026
Unlimited policies render only the Details card (no Settings card), so
with just `max-width` set the card shrinks to fit its sparse content
("Accrual type: Unlimited") and looks cramped. Add a min-width so the
card holds its shape regardless of content density.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Apply min-width: 320px only on the Details card when accrualMethod is 'unlimited', leaving limited-policy Details and Settings cards unaffected. Addresses Copilot review feedback on PR #1686. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeffredodd
force-pushed
the
fix/details-card-min-width
branch
from
0bff508 to
b8ace3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min-width: toRem(320)to.descriptionCardso the card holds shape regardless of content density.max-width: toRem(480)is preserved.This is PR 4 in the time-off bug-fix slate captured in
~/.claude/plans/ok-i-want-to-partitioned-balloon.md.Test plan
npm run test -- --run src/components/UNSTABLE_TimeOff/TimeOffPolicyDetail/— 36/36 passing (no behavior change)TimeOffPolicyDetailPresentationwithaccrualMethod: 'unlimited'— confirm Details card fills at least ~320px and renders cleanly🤖 Generated with Claude Code