fix: add icons to Holiday policy detail action buttons#1687
Open
jeffredodd wants to merge 1 commit intomainfrom
Open
fix: add icons to Holiday policy detail action buttons#1687jeffredodd wants to merge 1 commit intomainfrom
jeffredodd wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns UNSTABLE_TimeOff’s HolidayPolicyDetail header actions with the existing TimeOffPolicyDetail UX by adding the missing leading icons, and adds a regression test so those icons keep rendering.
Changes:
- Added
PlusCircleIconandEditIconto the “Add employees” and “Edit policy” buttons inHolidayPolicyDetail. - Added a regression test that asserts both action buttons render an
<svg>icon. - Keeps the holiday policy detail surface visually consistent with the regular time-off policy detail screen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/UNSTABLE_TimeOff/HolidayPolicyDetail/HolidayPolicyDetail.tsx |
Adds the missing leading icons to the two action buttons. |
src/components/UNSTABLE_TimeOff/HolidayPolicyDetail/HolidayPolicyDetail.test.tsx |
Adds test coverage for icon presence on both action buttons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add employees and Edit policy on the Holiday policy detail screen rendered without icons, while the equivalent buttons on the regular TimeOffPolicyDetail screen had PlusCircleIcon and EditIcon. Mirror that treatment so the two policy detail surfaces feel consistent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeffredodd
force-pushed
the
fix/holiday-detail-action-icons
branch
from
886cb4f to
3acc747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeOffPolicyDetailhadPlusCircleIconandEditIcon. Mirror that treatment so the two policy detail surfaces feel consistent.<svg>child.This is PR 5 in the time-off bug-fix slate captured in
~/.claude/plans/ok-i-want-to-partitioned-balloon.md.Test plan
npm run test -- --run src/components/UNSTABLE_TimeOff/HolidayPolicyDetail/— 8/8 passing (added 1 new icon-presence assertion)HolidayPolicyDetail— confirm both buttons show their iconTimeOffPolicyDetailstory to confirm consistent treatment🤖 Generated with Claude Code