Add option to unsign driver before packaging

[kostyanf14]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the driver packaging capabilities by introducing an option to unsign drivers prior to their inclusion in HLKX packages. This is achieved through an update to the rtoolsHCK dependency and the addition of a new command-line flag. The changes also include an improvement to the logging of package creation results, providing clearer feedback on success or failure.

Highlights

• New Feature: Unsign Driver Option: Introduced a new command-line option, --package-unsigned-driver, allowing users to remove signatures from drivers before they are included in an HLKX package. This provides greater flexibility in driver packaging workflows.
• Dependency Update: The rtoolsHCK gem has been updated from version v0.6.3 to v0.6.4, bringing in the necessary underlying functionality to support the new driver unsigning feature.
• Improved Package Creation Logging: Refactored the project package creation process to include a dedicated method for printing detailed results and warnings, enhancing visibility into the packaging outcome.

Changelog

• Gemfile
  • Updated the rtoolsHCK gem reference to version v0.6.4.
• Gemfile.lock
  • Updated the locked rtoolsHCK gem revision and version to 0.6.4.
• lib/cli.rb
  • Added a new package_unsigned_driver boolean property to CliTestOptions.
  • Introduced the --package-unsigned-driver command-line option to control driver signature removal.
• lib/engines/hcktest/tests.rb
  • Added a new private method print_project_package_results to standardize logging of package creation outcomes.
  • Modified create_project_package to accept and pass the remove_driver_signatures parameter to the rtoolsHCK method.
  • Updated create_project_package to use the new print_project_package_results method for logging.
• sorbet/rbi/gems/rtoolsHCK@0.6.4-39309cfbb5c1deeebae34c4019427803418ccd04.rbi
  • Renamed the RBI file to reflect the updated rtoolsHCK gem version and revision.
  • Updated the create_project_package method signature to include the remove_driver_signatures keyword argument.
  • Adjusted source line number references for various methods within the RBI file due to upstream changes in the rtoolsHCK gem.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR bumps rtoolsHCK to a version that supports removing driver signatures during project packaging, and wires that capability through the CLI into the HLKX package creation flow.

Changes:

• Bump rtoolsHCK from v0.6.3 to v0.6.4 and update Sorbet RBI for the new create_project_package option.
• Add --package-unsigned-driver CLI flag and a corresponding CliTestOptions property.
• Pass remove_driver_signatures into the package creation call and improve logging of packaging results.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sorbet/rbi/gems/rtoolsHCK@0.6.4-39309cfbb5c1deeebae34c4019427803418ccd04.rbi	Updates RBI signature to include remove_driver_signatures: keyword.
lib/engines/hcktest/tests.rb	Passes the new option into packaging and adds result logging.
lib/cli.rb	Adds package_unsigned_driver option and CLI flag.
Gemfile.lock	Locks rtoolsHCK to 0.6.4 git revision.
Gemfile	Updates rtoolsHCK git ref to v0.6.4.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request adds an option to unsign a driver before packaging it. However, a critical bug exists where a new keyword argument is passed to a method that does not support it, leading to an ArgumentError and application crash when the feature is used. Additionally, the error handling for the package creation process is incomplete, as it attempts to process and upload the package even if creation failed, which could lead to further crashes or incorrect behavior. These issues should be addressed to ensure the stability and reliability of the tool.

[kostyanf14]

rerun tests

[kostyanf14]

rerun tests