Various fixes to handling of chunk buffers#6184
Various fixes to handling of chunk buffers#6184fortnern wants to merge 14 commits intoHDFGroup:developfrom
Conversation
size checks in H5D__chunk_lock and H5Z_pipeline
|
Not scheduled for 2.1.0. Needs a test and doc updates to clarify the expected behavior of filters |
|
H5Zregister. Fix merge error.
|
996/3016 Test #30: H5TEST-dsets ...............................................................***Failed 3.59 sec Testing filter returning incorrect data size after unfiltering with vlen type |
Thanks, it only seems to happen on mac and sometimes windows. I might need help debugging this one if my last change doesn't fix it. |
|
Unfortunately, that test still failed. |
|
This should be brought up in SHINES. |



Verify uncompressed chunks are the right size after being uncompressed (reverse filtered)
Verify that the buffer returned from the filter callback is large enough to hold the returned data size
Fix bug in deflate filter that caused it to report the wrong buffer size
Fix bug in chunk copy code that could cause a background buffer overflow
Other general cleanup
The verification of the size of chunks after decompression causes a failure in NetCDF. I suspect this is an issue in that NetCDF test.
Important
Fixes and enhancements to chunk buffer handling, including size verification and buffer overflow prevention in
H5Dchunk.c,H5Z.c, andH5Zdeflate.c.H5Dchunk.c, verify uncompressed chunk size inH5D__chunk_lock()andH5D__chunk_copy_cb().H5Z.c, ensure buffer size is sufficient after filter callback inH5Z_pipeline().H5D__chunk_copy_cb()by ensuring background buffer size is adequate.H5Z__filter_deflate()inH5Zdeflate.c.bkg_sizeandsrc_chunk_sizetoH5D_chunk_it_ud3_tinH5Dchunk.c.H5Dchunk.candH5Z.c.This description was created by
for 7788329. You can customize this summary. It will automatically update as commits are pushed.