Merged
Conversation
jhendersonHDF
approved these changes
Apr 9, 2026
Collaborator
jhendersonHDF
left a comment
There was a problem hiding this comment.
Thanks @opoplawski. Did some basic testing and this seems fine.
brtnfld
approved these changes
Apr 9, 2026
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Apr 17, 2026
* Allow setting HDF5_INSTALL_JNI_LIB_DIR to specify install location for the JNI shared library * No library versioning for Java JNI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fedora Java packaging guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_guideline state that:
The first commit here allows changing the install location.
The second removes the library versioning from the JNI library. It is not necessary and discouraged. The Java loader will simply look for the
.sofile. The JAR and JNI library are always paired so versioning is not relevant.