Skip to content

fix: 修复 Windows 平台下 ModAdviser 没有正常工作的问题 #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CiiLu wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: 修复 Windows 平台下 ModAdviser 没有正常工作的问题 #5367

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d26f7b
update
CiiLu Jan 30, 2026
92cf2ad
update
CiiLu Jan 30, 2026
5358fe1
update
CiiLu Jan 30, 2026
b4a505a
update
CiiLu Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModAdviser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import org.jackhuang.hmcl.util.Lang;

import java.io.File;
import java.nio.file.FileSystems;
import java.util.List;

/**
Expand Down Expand Up @@ -74,7 +74,7 @@ enum ModSuggestion {
"optionsof.txt" /* OptiFine */,
"journeymap" /* JourneyMap */,
"optionsshaders.txt",
"mods" + File.separator + "VoxelMods");
"mods/VoxelMods");

static ModAdviser.ModSuggestion suggestMod(String fileName, boolean isDirectory) {
if (match(MODPACK_BLACK_LIST, fileName, isDirectory))
Expand All @@ -88,7 +88,7 @@ static ModAdviser.ModSuggestion suggestMod(String fileName, boolean isDirectory)
static boolean match(List<String> l, String fileName, boolean isDirectory) {
for (String s : l)
if (isDirectory) {
if (fileName.startsWith(s + File.separator))
if (fileName.startsWith(s + "/") || fileName.startsWith(s + FileSystems.getDefault().getSeparator()))
return true;
} else {
if (s.startsWith("regex:")) {
Expand Down