Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在优化 TwoLineListItem 第一行中标签(tags)的展示方式,避免标签内容对布局造成不良影响,并配套调整样式选择器以适配新的节点结构。
Changes:
- 在
TwoLineListItem中用ScrollPane包裹标签容器,使标签区域具备可裁剪的视口能力 - 调整
firstLine的对齐方式为CENTER_LEFT - 更新 root.css 中 tags 相关选择器,并新增针对滚动条显示/占位的样式规则
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/css/root.css | 更新 tags 选择器以适配新增的 ScrollPane 包裹层,并尝试隐藏滚动条占位 |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TwoLineListItem.java | 为 tags 区域引入 ScrollPane 包裹并调整布局对齐 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.