Skip to content

Majd hussein react w1#8

Open
Majoodeh wants to merge 16 commits intoHackYourAssignment:mainfrom
Majoodeh:MAJD-HUSSEIN_React-w1
Open

Majd hussein react w1#8
Majoodeh wants to merge 16 commits intoHackYourAssignment:mainfrom
Majoodeh:MAJD-HUSSEIN_React-w1

Conversation

@Majoodeh
Copy link
Copy Markdown

crevulus and others added 14 commits June 19, 2025 11:32
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.11 to 5.4.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Copy Markdown

@JalalHabeeb JalalHabeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The app is working, but as a React application, you should use states to switch the state of a component.
  • The components folder should be inside the src folder, where all other project files are.
  • The file name of a component should start with a Capital letter: Category.tsx. It's not wrong if it's not, but it's preferred.
  • Mind the typos in the variable names. For example: button not buttun

Comment thread week1/project/ecommerce/components/category.jsx Outdated
return;
}
buttunsArr.push(button);
console.log("button ++++", buttunsArr);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All console logs should be removed after finishing building the project.

Comment thread week1/project/ecommerce/src/App.jsx Outdated
Comment thread week1/project/ecommerce/src/App.jsx Outdated

console.log("Buttons", CategoryBtn);
function App() {
const [count, setCount] = useState(0);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this state should be removed

Comment thread week1/project/ecommerce/src/App.jsx
Comment thread week1/project/ecommerce/src/App.css Outdated
Comment thread week1/project/extra_code.js
Comment thread week1/project/ecommerce/src/components/category.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants