Salem Ba-Rabuod

[Barboud]

No description provided.

[remarcmij]

Hi @Barboud , see my comments below with regard to Task 1. The code of that you originally submitted as your PR for me to review could never have worked because of the reasons I explained in Slack. I consider that a submission that was not tested by yourself.

[remarcmij]

It is best to define these constants outside of the class definition so that you can use them in all methods, not just the constructor.

Suggested change

	export class Time {
	const SECONDS_IN_MINUTE = 60;
	const SECONDS_IN_HOUR = SECONDS_IN_MINUTE * 60;
	const SECONDS_IN_DAY = SECONDS_IN_HOUR * 24;
	export class Time {

[remarcmij]

Use the suggested constants defined at the file level.

Suggested change

	const SECONDS_IN_HOUR = 3600;
	const SECONDS_IN_MINUTE = 60;

[remarcmij]

86400 is a magic number.

Suggested change

	if (totalSeconds < 0 || totalSeconds >= 86400) {
	if (totalSeconds < 0 || totalSeconds >= SECONDS_IN_DAY) {

[remarcmij]

Suggested change

	return Math.floor(this.#secondsFromMidnight / 3600);
	return Math.floor(this.#secondsFromMidnight / SECONDS_IN_HOUR);

[remarcmij]

Suggested change

	return Math.floor((this.#secondsFromMidnight % 3600) / 60);
	return Math.floor((this.#secondsFromMidnight % SECONDS_IN_HOUR) / SECONDS_IN_MINUTE);

[remarcmij]

Check the rest of this class for magic number and replace them with the predefined constants.

[remarcmij]

To make this class reusable, this file should only define the class itself. These statements belong to the index.js file.

Suggested change

	const myTime = new Time(12, 35, 0);
	console.log(myTime.toString()); // 12:35:00
	myTime.getHours(); // 12
	myTime.getMinutes(); // 35
	myTime.getSeconds(); // 0
	myTime.addMinutes(25);
	console.log(myTime.toString()); // 13:00:00
	myTime.addHours(12);
	console.log(myTime.toString()); // 01:00:00

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

[Barboud]

Hi @Barboud , see my comments below with regard to Task 1. The code of that you originally submitted as your PR for me to review could never have worked because of the reasons I explained in Slack. I consider that a submission that was not tested by yourself.

Hi @remarcmij , I’ve updated the code for Task 1 and addressed the issues you mentioned. For task 2, I’ve also thoroughly tested it on my end to ensure everything is working correctly now.