Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 100 / 100 ✅Status: ✅ Passed Test Details |
durw4rd
reviewed
Mar 17, 2026
| */ | ||
| export function fetchNobelPrizes(filters = {}, onSuccess, onError) { | ||
| let url = ''; // TODO Construct the full URL with query parameters; | ||
| let url = `${API_BASE_URL}/nobelPrizes?offset=${filters.offset}&limit=${filters.limit}&sort=desc`; |
There was a problem hiding this comment.
On one hand, I like the concise syntax; on the other, the instructions mention the following:
Tip: Use the URLSearchParams Web API to build the query string. It handles encoding and formatting for you.
The automatic URL encoding would be handy if not covered by the imported fetchData function (I didn't check, but suspect that might be the case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete assignment for week 9