Skip to content

Fix the ktlint failures already present on develop - #3111

Merged
StylianosGakis merged 1 commit into
developfrom
chore/fix-ktlint-formatting
Sep 8, 2026
Merged

Fix the ktlint failures already present on develop#3111
StylianosGakis merged 1 commit into
developfrom
chore/fix-ktlint-formatting

Conversation

@StylianosGakis

@StylianosGakis StylianosGakis commented Aug 28, 2026

Copy link
Copy Markdown
Member

Fix some red warnings to make the rest of the stack cleaner

🤖 AI description:

ktlintCheck fails on develop with two standard:max-line-length errors, unrelated to any in-flight work. Left alone it makes any PR that touches ktlint config look like it broke CI, which is why this sits at the bottom of the stack: the PR above adds a new ktlint rule, and that rule is only trustworthy if the task it runs under is otherwise clean.

That rule is not auto-fixable, so this is a hand fix. The same 127 character description string appears in two previews in TerminationRedirectionDestination.kt and is now split across two literals.

Repo-wide ktlintCheck goes from 2 errors to 0, and stays at 0 from the top of the stack. The module still compiles.

@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch from 0a70e05 to dbc532e Compare August 28, 2026 20:55
@StylianosGakis
StylianosGakis changed the base branch from chore/namespace-import-ktlint-rule to develop August 28, 2026 20:55
@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch from dbc532e to d72a3c2 Compare September 3, 2026 08:31
@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch 2 times, most recently from 25fe0ff to 4953c5d Compare September 4, 2026 16:52
`./gradlew ktlintCheck` fails on develop with two `standard:max-line-length`
errors, unrelated to any in-flight work. Left alone it makes any PR that
touches ktlint config look like it broke CI.

The rule is not auto-fixable, so this is a hand fix: the same 127 character
description string appears in two previews and is now split across two
literals.
@StylianosGakis
StylianosGakis marked this pull request as ready for review September 7, 2026 14:54
@StylianosGakis
StylianosGakis requested a review from a team as a code owner September 7, 2026 14:54
@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch from 4953c5d to c1cc339 Compare September 7, 2026 14:59
@StylianosGakis
StylianosGakis merged commit e57b29a into develop Sep 8, 2026
4 checks passed
@StylianosGakis
StylianosGakis deleted the chore/fix-ktlint-formatting branch September 8, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants