Delete the lint baselines that suppress nothing - #3132
Merged
StylianosGakis merged 1 commit intoSep 8, 2026
Conversation
StylianosGakis
force-pushed
the
chore/delete-empty-lint-baselines
branch
from
September 4, 2026 16:52
d6369d5 to
fc49ec2
Compare
104 of the 105 checked-in baselines contain no entries. They existed only because lint used to abort whenever it had to create a missing baseline, so every module the convention plugin touched needed the file whether it suppressed anything or not. Lint no longer requires them, so a baseline in the tree now means what it says: this module suppresses findings. Deleting the empty ones makes the tree match that. `lint-baseline-core-resources.xml` stays. Its 39 entries are the only ones carrying information, and they are the record of what would surface if AGP ever gives KMP modules a runnable lint task. A module that needs a baseline from here creates the file empty and fills it with `updateLintBaseline`, which the convention plugin documents.
StylianosGakis
marked this pull request as ready for review
September 7, 2026 14:54
StylianosGakis
force-pushed
the
chore/delete-empty-lint-baselines
branch
from
September 7, 2026 15:00
fc49ec2 to
29ee588
Compare
panasetskaya
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete all the empty baseline files which were noise without giving us any benefit
🤖 AI description:
The systematic half of #3121. That PR stopped lint requiring a baseline per module; this deletes the ones that requirement produced.
What goes. 104 of the 105 checked-in baselines contain no entries at all, and all 104 are byte-identical at 188 bytes. They existed only because lint aborts whenever it has to create a missing baseline, so every module the convention plugin touched needed the file whether it suppressed anything or not.
With #3121 in place a baseline now means what it says: this module suppresses findings. These 104 said nothing.
What stays.
lint-baseline-core-resources.xml, whose 39 entries are the only ones carrying information. It is also the record of what would surface if AGP ever gives KMP modules a runnable lint task, which is why it is worth keeping even though nothing enforces it today (it was generated by lint 8.8.0-alpha09 and cannot be regenerated, since that module has no lint task).Verified a no-op. An empty baseline suppresses nothing, so removing it cannot change a result. Confirmed by running the full
./gradlew lintwith all 104 gone: BUILD SUCCESSFUL, no baseline recreated, no untracked files left behind.Adding a baseline from here. Create the file empty, then fill it with
updateLintBaseline. The task is a no-op when no file exists, and the convention plugin's comment says so at the point wherebaselineis set.