Rename the liquid glass button internals to match Figma - #3137
Merged
StylianosGakis merged 1 commit intoSep 8, 2026
Merged
Conversation
StylianosGakis
marked this pull request as ready for review
September 7, 2026 14:20
StylianosGakis
force-pushed
the
design-system/glass-button-tokens-rename
branch
from
September 7, 2026 14:24
c99aa17 to
d38b2ab
Compare
StylianosGakis
force-pushed
the
design-system/glass-button-tokens-rename
branch
from
September 7, 2026 15:42
d38b2ab to
8f66e4c
Compare
StylianosGakis
changed the title
panasetskaya
approved these changes
Sep 8, 2026
RoundedLargeSizeButtonTokens -> LiquidGlassButtonTokens, Size.LargeRounded -> Size.LiquidGlass, and the two private Style objects RoundedPrimary / RoundedLiquidGlass -> LiquidGlassTinted / LiquidGlassRegular. Figma models both of these as one component, 'Button - Liquid Glass - Text' (node 1:6724), with a boolean Tinted variant. Since #3126 made every button a pill, 'rounded' and 'large' no longer describe anything; these are the liquid glass metrics, drawn at one fixed size. Pure rename, no behaviour change.
StylianosGakis
force-pushed
the
design-system/glass-button-tokens-rename
branch
from
September 8, 2026 10:41
8f66e4c to
671c93f
Compare
StylianosGakis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming of the glass buttons to better just explain what they are and why it's there
🤖 AI description:
📄 The button seam — visual walkthrough of this stack.
Pure rename, no behaviour change:
RoundedLargeSizeButtonTokens→LiquidGlassButtonTokensSize.LargeRounded→Size.LiquidGlassStyle.RoundedPrimary/Style.RoundedLiquidGlass→Style.LiquidGlassTinted/Style.LiquidGlassRegularSince #3126 made every button a pill, neither "rounded" nor "large" describes these any more. Figma models both buttons as one component,
Button - Liquid Glass - Text(node1:6724), with a booleanTintedvariant, so the names follow that. Split out from #3138 so that one's diff is about structure rather than rename noise.