Make iszero throw FPTNException; add iszero_tn - #25
Open
timholy wants to merge 1 commit into
Open
Conversation
When `X` contains both zero and nonzero values, `iszero(X)` cannot return a single `Bool`, so like `==` it violates the Fundamental Principle of Thick Numbers. Breaking change: iszero now throws for thick numbers. Use iszero_tn for the additive identity test, including ForwardDiff partials. The new predicate also accepts point numbers. Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 94.00% 94.15% +0.15%
==========================================
Files 2 2
Lines 150 154 +4
==========================================
+ Hits 141 145 +4
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Xcontains both zero and nonzero values,iszero(X)cannotreturn a single
Bool, so like==it violates the FundamentalPrinciple of Thick Numbers.
Breaking change: iszero now throws for thick numbers. Use iszero_tn
for the additive identity test, including ForwardDiff partials.
The new predicate also accepts point numbers.
Assisted-by: Claude Fable 5.1 noreply@anthropic.com