Add Table and DataTable block support#455
Merged
Merged
Conversation
yyakhnytsia
reviewed
Jun 19, 2026
yyakhnytsia
left a comment
Contributor
There was a problem hiding this comment.
Reviewed, left comments.
| @JsonSubTypes( | ||
| { | ||
| @JsonSubTypes.Type(value = RawTextTableCell.class, name = RawTextTableCell.TYPE), | ||
| @JsonSubTypes.Type(value = RichTextTableCell.class, name = RichTextTableCell.TYPE), |
Contributor
There was a problem hiding this comment.
Could you please check if we shouldn't include RawNumberTableCellIF here as well
Contributor
Author
There was a problem hiding this comment.
In documentation it says that Tables supports RawNumberTableCell, but in practice / what's actually implemented it doesn't support it. Not sure where the right place to raise that issue is to Slack, but I've omitted RawNumberTableCell here because of that.
Contributor
|
@VictorHLi404 Do you have access to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New files
Production:
Tests:
Test plan
🤖 Generated with Claude Code