Fix key rotation #160
Open
Fix key rotation #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aram356
requested changes
Jan 22, 2026
Collaborator
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
👍 Looks good overall. I added small nitpicks to address.
crates/common/src/fastly_storage.rs
Outdated
|
|
||
| Ok(Self { | ||
| api_key, | ||
| base_url: "https://api.fastly.com".to_string(), |
docs/guide/key-rotation.md
Outdated
| [local_server.secret_stores] | ||
| [[local_server.secret_stores.signing_keys]] | ||
| key = "ts-2025-01-01" | ||
| data = "NVnTYrw5xoyTJDOwoUWoPJO3A6UCCXOJJUzgGTxxx7k=" |
Collaborator
There was a problem hiding this comment.
⛏️ Use placeholder in place actual key
docs/guide/key-rotation.md
Outdated
| ```toml | ||
| [request_signing] | ||
| enabled = true | ||
| config_store_id = "r8loXvD9GESm5Crw5oyS16" # Your jwks_store ID |
Collaborator
There was a problem hiding this comment.
⛏️ Use placeholder in place actual store id
| let secret_store = FastlySecretStore::new(store_name); | ||
| let api_key = secret_store.get(key_name)?; | ||
|
|
||
| log::info!("FastlyApiClient initialized with backend: {}", backend_name); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using hardcoded backend names, we later added port number to the dynamic backend names which broke the key rotation.
Now the fastly client will use the generated backend name.
closes #185