Skip to content

Standardize IntegrationConfig trait imports #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prk-Jr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Standardize IntegrationConfig trait imports #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/common/src/integrations/lockr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ use crate::integrations::{
AttributeRewriteAction, IntegrationAttributeContext, IntegrationAttributeRewriter,
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
};
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
use crate::settings::{IntegrationConfig, Settings};

const LOCKR_INTEGRATION_ID: &str = "lockr";

Expand Down Expand Up @@ -68,7 +68,7 @@ pub struct LockrConfig {
pub rewrite_sdk_host: bool,
}

impl IntegrationConfigTrait for LockrConfig {
impl IntegrationConfig for LockrConfig {
fn is_enabled(&self) -> bool {
self.enabled
}
Expand Down
4 changes: 2 additions & 2 deletions crates/common/src/integrations/permutive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use crate::integrations::{
AttributeRewriteAction, IntegrationAttributeContext, IntegrationAttributeRewriter,
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
};
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
use crate::settings::{IntegrationConfig, Settings};

const PERMUTIVE_INTEGRATION_ID: &str = "permutive";

Expand Down Expand Up @@ -61,7 +61,7 @@ pub struct PermutiveConfig {
pub rewrite_sdk: bool,
}

impl IntegrationConfigTrait for PermutiveConfig {
impl IntegrationConfig for PermutiveConfig {
fn is_enabled(&self) -> bool {
self.enabled
}
Expand Down
4 changes: 2 additions & 2 deletions crates/common/src/integrations/testlight.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use crate::integrations::{
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
};
use crate::proxy::{proxy_request, ProxyRequestConfig};
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
use crate::settings::{IntegrationConfig, Settings};
use crate::synthetic::{generate_synthetic_id, get_or_generate_synthetic_id};
use crate::tsjs;

Expand All @@ -37,7 +37,7 @@ pub struct TestlightConfig {
pub rewrite_scripts: bool,
}

impl IntegrationConfigTrait for TestlightConfig {
impl IntegrationConfig for TestlightConfig {
fn is_enabled(&self) -> bool {
self.enabled
}
Expand Down
Loading