Add integration testing with testcontainers and Playwright by prk-Jr · Pull Request #442 · IABTechLab/trusted-server

prk-Jr · 2026-03-05T14:11:12Z

Summary

Add end-to-end integration testing infrastructure using testcontainers for HTTP-level tests and Playwright for browser tests against WordPress and Next.js containers
Add Playwright browser tests verifying script injection, SPA navigation, deferred script execution, API passthrough, and form URL rewriting in a real Chromium browser
Introduce a /health endpoint and CI workflow for running both test suites separately from the main CI

Changes

File	Change
`crates/fastly/src/main.rs`	Add `/health` GET endpoint returning 200 with "ok" body
`crates/integration-tests/Cargo.toml`	New crate with reqwest, testcontainers, and tokio dependencies
`crates/integration-tests/tests/common/`	Core test infrastructure: runtime traits, config builder, assertion helpers including `assert_form_action_rewritten` (9 unit tests)
`crates/integration-tests/tests/environments/`	Fastly/Viceroy runtime environment with dynamic port allocation
`crates/integration-tests/tests/frameworks/`	Framework abstractions for WordPress and Next.js with 7 standard + 5 custom scenarios
`crates/integration-tests/tests/integration.rs`	Matrix test runner (`test_all_combinations`, per-framework tests)
`crates/integration-tests/fixtures/configs/`	Viceroy and Fastly config templates with KV stores and secrets
`crates/integration-tests/fixtures/frameworks/wordpress/`	WordPress Docker image: PHP built-in server with minimal test theme and `/wp-admin/` stub
`crates/integration-tests/fixtures/frameworks/nextjs/`	Next.js 14 Docker image: 4 pages, API routes, forms, shared navigation with hydration signal, deferred route scripts
`crates/integration-tests/browser/`	Playwright test suite: global setup/teardown, Docker + Viceroy infra helpers with cleanup-on-failure
`crates/integration-tests/browser/tests/shared/`	Cross-framework browser tests: script injection, script bundle loading
`crates/integration-tests/browser/tests/nextjs/`	Next.js browser tests: 4-page SPA navigation chain, deferred script execution, API passthrough, form URL rewriting
`crates/integration-tests/browser/tests/wordpress/`	WordPress browser tests: admin page script injection
`.github/workflows/integration-tests.yml`	CI workflow with parallel HTTP-level and browser test jobs, split artifact uploads for Playwright reports and traces
`scripts/integration-tests.sh`	Shell script for HTTP-level test orchestration (WASM build + Docker + test run)
`scripts/integration-tests-browser.sh`	Shell script for browser test orchestration (WASM build + Docker + Playwright install + test run)
`crates/integration-tests/README.md`	Full documentation: prerequisites, quick start, test scenario tables, architecture overview
`INTEGRATION_TESTS_PLAN.md`	Design document with architecture decisions and progress tracking
`Cargo.toml`	Add integration-tests to workspace members
`Cargo.lock`	Updated lockfile with new dependencies

Test coverage

HTTP-level (Rust + testcontainers)

Scenario	Frameworks
`HtmlInjection`	WordPress, Next.js
`ScriptServing`	WordPress, Next.js
`AttributeRewriting`	WordPress, Next.js
`ScriptServingUnknownFile404`	WordPress, Next.js
`WordPressAdminInjection`	WordPress
`NextJsRscFlight`	Next.js
`NextJsServerActions`	Next.js
`NextJsApiRoute`	Next.js
`NextJsFormAction`	Next.js

Browser-level (Playwright + Chromium)

Spec	Frameworks
`script-injection`	WordPress, Next.js
`script-bundle`	WordPress, Next.js
`navigation` (4-page SPA chain + back button + deferred route script)	Next.js
`api-passthrough`	Next.js
`form-rewriting`	Next.js
`admin-injection`	WordPress

Totals: 12 Next.js + 5 WordPress browser tests, 0 flaky

Known gaps

GDPR consent propagation — the consent field exists in AuctionRequest but is not yet populated upstream. Requires implementation before it can be tested.
Browser suite uses manual Docker orchestration — HTTP-level tests use the Rust testcontainers crate; browser tests use docker run/docker stop via Playwright's globalSetup/globalTeardown (Node.js cannot use the Rust crate).

Closes

Closes #398

Test plan

Checklist

Changes follow CLAUDE.md conventions
No unwrap() in production code — use expect("should ...")
Uses log macros (not println!)
New code has tests (9 unit tests for assertions and config, 17 browser tests)
No secrets or credentials committed

The integration-tests crate defines traits, error types, and helpers consumed by Docker-dependent tests. Without Docker the compiler sees them as unused and -D warnings promotes them to errors. A crate-level allow keeps CI green.

Proves that a next/script with strategy="afterInteractive" executes after a client-side navigation through the trusted-server proxy. The test SPA-navigates from / to /dashboard, waits for the script's global marker, asserts it ran exactly once, and confirms no document-level request fired (true SPA, not full reload).

…hub.com-prkjr:IABTechLab/trusted-server into feature/integration-testing-with-testcontainers

aram356

Solid integration testing infrastructure. The RuntimeEnvironment + FrontendFramework matrix design is clean and extensible, the two-layer approach (Rust HTTP + Playwright browser) gives good coverage, and the assertion library having its own unit tests is a nice touch.

Cross-cutting notes

📝 Separate Cargo.lock — The 3400-line crates/integration-tests/Cargo.lock is disconnected from the workspace lock. If error-stack (or any shared dep) is updated in the workspace but not here, they silently diverge. Consider documenting the upgrade process or adding a CI check that validates shared dependency versions stay in sync.

📝 Viceroy config placeholders — viceroy-template.toml uses key = "placeholder" / data = "placeholder" for all KV stores. This means integration tests don't exercise KV store functionality, which is fine but worth a comment in the config noting this intentional scope limitation.

⛏ .gitignore missing trailing newline — The last line lacks a POSIX-compliant trailing newline.

What's done well

👍 Drop impl on ViceroyHandle ensures process cleanup even on panics — good defensive design.

👍 Assertion functions (assertions.rs) have thorough unit tests covering both passing and failing cases.

👍 Browser tests use hydration detection (data-hydrated attribute) before SPA navigation — avoids the classic "clicked before client router was ready" flake.

👍 Health check endpoint is namespaced (/__trusted-server/health) to minimize publisher route conflicts.

👍 Shell scripts detect native target dynamically via rustc -vV — no hardcoded platform assumptions.

👍 Smart use of PHP built-in server for WordPress fixture — avoids MySQL dependency while still testing real HTML processing behavior.

crates/integration-tests/browser/playwright.config.ts

crates/integration-tests/fixtures/frameworks/nextjs/Dockerfile

scripts/integration-tests-browser.sh

crates/fastly/src/main.rs

crates/integration-tests/browser/helpers/infra.ts

crates/integration-tests/tests/frameworks/nextjs.rs

crates/integration-tests/browser/tests/shared/script-injection.spec.ts

crates/integration-tests/tests/environments/mod.rs

.github/workflows/integration-tests.yml

aram356 · 2026-03-10T07:51:35Z

.github/workflows/integration-tests.yml

+    branches: [main]
+  pull_request:
+  pull_request_review:
+    types: [submitted]


🌱 pull_request_review trigger means integration tests re-run on every review submission, even when no code changed. Combined with the pull_request trigger, an approval on an existing PR triggers a full redundant run. Consider removing this trigger or using workflow_dispatch for on-demand runs.

crates/integration-tests/fixtures/frameworks/nextjs/Dockerfile

ChristianPavilonis

See below

ChristianPavilonis

One follow-up I still recommend:

.github/workflows/integration-tests.yml currently runs on pull_request_review approvals, which can trigger full integration + browser reruns without any code change.
Severity: P2 (efficiency/cost)
Suggestion: remove the pull_request_review trigger and keep pull_request + workflow_dispatch for canonical/manual runs.
Verdict: needs discussion (not a hard blocker).

ChristianPavilonis · 2026-03-12T14:50:58Z

.github/workflows/integration-tests.yml

+  pull_request_review:
+    types: [submitted]


P2 (efficiency/cost): pull_request_review triggers will re-run the full integration + browser test suites on every review submission — even when there are no code changes. Consider removing this trigger and keeping just pull_request + workflow_dispatch for canonical/manual runs.

prk-Jr added 2 commits March 5, 2026 16:02

Wip integration testing with testcontainers

ac612b2

Feature integration test with TestContainers

2d2600e

prk-Jr self-assigned this Mar 5, 2026

prk-Jr marked this pull request as draft March 5, 2026 14:12

prk-Jr added 7 commits March 5, 2026 20:12

wip: integration tests

a02c080

wip: AttributeRewriting

e9e466c

HTTP-level improvements

fef992f

Enrich Next.js fixture and add browser integration tests

582f80c

Update integration test documentation to reflect current state

1d79015

prk-Jr changed the title ~~Add integration testing infrastructure with testcontainers~~ Add integration testing with testcontainers and Playwright Mar 7, 2026

prk-Jr and others added 7 commits March 7, 2026 13:55

Temporarily trigger integration tests on PR push

814b6d2

Add pull_request to job-level if conditions

b903635

Fix path for wasm binary in ci

eb2aa1c

Merge branch 'main' into feature/integration-testing-with-testcontainers

9340a86

Harden integration test infrastructure and fix production conventions

012b8bd

Merge branch 'feature/integration-testing-with-testcontainers' of git…

867d4e5

…hub.com-prkjr:IABTechLab/trusted-server into feature/integration-testing-with-testcontainers

Update integration tests for latest error-stack API

4dc2d3c

prk-Jr marked this pull request as ready for review March 9, 2026 14:47

aram356 requested changes Mar 10, 2026

View reviewed changes

crates/integration-tests/fixtures/frameworks/nextjs/Dockerfile Outdated Show resolved Hide resolved

Harden integration test dependency and fixture reproducibility

437a9f4

aram356 requested review from ChristianPavilonis March 11, 2026 16:00

ChristianPavilonis reviewed Mar 11, 2026

View reviewed changes

ChristianPavilonis reviewed Mar 12, 2026

View reviewed changes

Trigger integration test on pull requets only

5b00113

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration testing with testcontainers and Playwright#442

Add integration testing with testcontainers and Playwright#442
prk-Jr wants to merge 18 commits intomainfrom
feature/integration-testing-with-testcontainers

prk-Jr commented Mar 5, 2026 •

edited

Loading

Uh oh!

aram356 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aram356 Mar 10, 2026

Uh oh!

Uh oh!

ChristianPavilonis left a comment •

edited

Loading

Uh oh!

ChristianPavilonis left a comment •

edited

Loading

Uh oh!

ChristianPavilonis Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

prk-Jr commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test coverage

HTTP-level (Rust + testcontainers)

Browser-level (Playwright + Chromium)

Known gaps

Closes

Test plan

Checklist

Uh oh!

aram356 left a comment

Choose a reason for hiding this comment

Cross-cutting notes

What's done well

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aram356 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChristianPavilonis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristianPavilonis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristianPavilonis Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prk-Jr commented Mar 5, 2026 •

edited

Loading

ChristianPavilonis left a comment •

edited

Loading

ChristianPavilonis left a comment •

edited

Loading