Skip to content

Fix bugs, compiler warnings, and test includes from commit review - #10

Open
IAKOBVS wants to merge 1 commit into
masterfrom
fix/review-latest-commits-bugs-1981864023977431433
Open

Fix bugs, compiler warnings, and test includes from commit review#10
IAKOBVS wants to merge 1 commit into
masterfrom
fix/review-latest-commits-bugs-1981864023977431433

Conversation

@IAKOBVS

@IAKOBVS IAKOBVS commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Reviewed the 2 latest commits (8379140 and e66b9f5) and fixed identified issues:

  1. Fixed potential buffer overflow in jstr_repeat_len (include/replace.h) by checking for n > (SIZE_MAX - 1) / *sz and handling *sz == 0.
  2. Resolved -Wunused-variable and -Wunused-function compiler warnings in tests/test-io-extra5.c and tests/test-io-ftw2.c.
  3. Fixed build error in tests/test-nosimd.c by updating header path to "jstr.h".
  4. Recompiled and verified all 126 test variants pass with 0 failures.

PR created automatically by Jules for task 1981864023977431433 started by @IAKOBVS

- Add zero size and integer overflow protection in jstr_repeat_len
- Clean up unused static functions and variables in test-io-extra5 and test-io-ftw2
- Update test-nosimd to use standard jstr.h include path

Co-authored-by: IAKOBVS <89495599+IAKOBVS@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant