Draft
Conversation
|
|
Member
|
Hey @gameroman, thanks for the contribution. We'll try to look into the PR soon, but I'd like to ask two things in the meantime:
|
diatrcz
requested changes
Apr 14, 2026
Comment on lines
+248
to
+252
| const options = { ...parameters.defaultOptions, ...parameters.options }; | ||
| let headers = { ...parameters.defaultOptions?.headers, ...parameters.options?.headers }; | ||
| const qs = { ...parameters.defaultOptions?.qs, ...parameters.options?.qs }; | ||
| const { path, body, form, formData, method, serviceUrl, axiosOptions } = options; | ||
| let { url } = options; |
Contributor
There was a problem hiding this comment.
With this change if parameters.options contains nested objects, they get replaced entirely rather than merged with. This differs from the previous deep merge behaviour provided by extend.
I added a new test case in the main branch testing this specific edge case.
Contributor
|
Hi @gameroman, thank you for the contribution. Additionally to the change requests:
|
Author
|
Thank you for the review, I’ll fix everything when I get back👍 |
gameroman
force-pushed
the
replace-extend
branch
from
c0c56c1 to
a1e1ea2
Compare
Co-authored-by: Tarcza Lídia <100163235+diatrcz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)