IDEX l1a event messages#2870
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for decoding IDEX event-message packets into rendered, human-readable message strings and writing them to a dedicated L1A “msg” CDF product, along with the needed CDF metadata and updated tests.
Changes:
- Introduces template-based rendering for IDEX event messages using IDEX-provided lookup dictionaries.
- Updates IDEX L1A processing to generate an
imap_idex_l1a_msgdataset with amessagesvariable. - Extends CDF global/variable attribute configs and updates the L1A event-message test expectations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| imap_processing/tests/idex/test_idex_l1a.py | Updates EVT test to expect “msg” product naming and validates rendered messages against example data. |
| imap_processing/idex/idex_l1a.py | Adds message-product processing (process_idex_msg_data) and renders event messages into a new dataset variable. |
| imap_processing/idex/idex_evt_msg_parsing_dictionaries.json | Adds IDEX-provided dictionaries/templates used for decoding event messages. |
| imap_processing/idex/evt_msg_decode_utils.py | Adds placeholder/template rendering utility for event message strings. |
| imap_processing/cdf/config/imap_idex_l1a_variable_attrs.yaml | Adds CDF variable attributes for the new messages variable. |
| imap_processing/cdf/config/imap_idex_global_cdf_attrs.yaml | Renames/updates global attributes for msg products and their metadata fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This has been tested successfully locally and in dev. |
That is helpful to know! |
tech3371
left a comment
There was a problem hiding this comment.
The code changes looks good. I had minor requests for variable names updates for easier readability in the future when we don't have much context of the background. Can you make those changes? Otherwise, the code is solid and makes lot of sense!
tech3371
left a comment
There was a problem hiding this comment.
Looks great! Thank you for making those changes!
88244c9
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
Parse and write all IDEX event messages out to the msg l1a CDF
File changes
imap_processing/cdf/config/imap_idex_global_cdf_attrs.yaml
- update descriptor
Testing
Update l1a event message test